1730560 - New tab customize checkbox checkmark is hard to see on light theme

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

Attachment: dark check on dark blue for light theme

Looks like the checkbox check got switched but not the slider toggle. Unclear if they should be the same as each other?

--customize-menu-check-fill: #{$newtab-card-primary-text-color};
 --customize-menu-primary-action-text: #{$white};

https://searchfox.org/mozilla-central/rev/5f81c5091d442d829120e19477ba869ae5219709/browser/components/newtab/content-src/styles/_theme.scss#111,119

Comment 1

[Harry Twyford]

Attachment: Bug 1730560 - Fix newtab customize checkbox color. r?Mardak!

This patch also renames --customize-menu-primary-action-text to --customize-menu-slider-fill, since that's the only place its used.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b1f394b6cb2
Fix newtab customize checkbox color. r=Mardak

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1726432

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9b1f394b6cb2

Comment 5

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the checkmark is white on a blue background for the Light theme, and the checkmark is black on a light blue background on Dark theme using Firefox 94.0a1 (Build ID: 20210923214525) on Windows 10 x64, macOS 11.6, and Ubuntu Linux 20.04 x64.