Closed
Bug 1726432
Opened 3 years ago
Closed 3 years ago
Remove unused NTP theme variables
Categories
(Firefox :: New Tab Page, enhancement, P2)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: amy, Assigned: bugzilla)
References
Details
(Whiteboard: [fidefe-theme])
Attachments
(4 files)
Remove unused variables within _theme.scss and _variables.scss
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → htwyford
Severity: -- → N/A
Status: NEW → ASSIGNED
Iteration: --- → 93.1 - Aug 9 - Aug 22
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
This is the variable we will eventually replace with ntp_secondary or equivalent.
Depends on D123384
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D123385
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D123386
|
||
Updated•3 years ago
|
Attachment #9237571 -
Attachment description: WIP: Bug 1726432 - Part 1 - Remove newtab-experience class. r?amy! → Bug 1726432 - Part 1 - Remove newtab-experience class. r?amy!
|
|
||
Updated•3 years ago
|
Attachment #9237573 -
Attachment description: WIP: Bug 1726432 - Part 3 - Consolidate variables with their '-nte' equivalents. r?amy! → Bug 1726432 - Part 3 - Consolidate variables with their '-nte' equivalents. r?amy!
|
|
||
Updated•3 years ago
|
Attachment #9237574 -
Attachment description: WIP: Bug 1726432 - Part 4 - Remove unused variables. r?amy! → Bug 1726432 - Part 4 - Remove unused variables. r?amy!
|
|
Assignee | |
Updated•3 years ago
|
Whiteboard: [fidefe-theme]
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Attachment #9237572 -
Attachment description: WIP: Bug 1726432 - Part 2 - Consolidate newtab-background-secondary variable. → Bug 1726432 - Part 2 - Consolidate newtab-background-secondary variable.
|
Reporter | |
Updated•3 years ago
|
Iteration: 93.1 - Aug 9 - Aug 22 → 93.2 - Aug 23 - Sep 5
|
|
Reporter | |
Updated•3 years ago
|
Iteration: 93.2 - Aug 23 - Sep 5 → ---
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae9421f6d1ec
Part 1 - Remove newtab-experience class. r=amy
https://hg.mozilla.org/integration/autoland/rev/259f59645340
Part 2 - Consolidate newtab-background-secondary variable. r=amy
https://hg.mozilla.org/integration/autoland/rev/a09beb8bff57
Part 3 - Consolidate variables with their '-nte' equivalents. r=amy
https://hg.mozilla.org/integration/autoland/rev/978a31ae4623
Part 4 - Remove unused variables. r=amy
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ae9421f6d1ec
https://hg.mozilla.org/mozilla-central/rev/259f59645340
https://hg.mozilla.org/mozilla-central/rev/a09beb8bff57
https://hg.mozilla.org/mozilla-central/rev/978a31ae4623
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•