1730798 - Port bug 1713605 - Use NSS only on socket thread in CertVerifier::VerifySSLServerCert

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1730798 - Port bug 1713605 - Use NSS only on socket thread in CertVerifier::VerifySSLServerCert. r=benc

Depends on D125623

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c894a3a6a723
Port bug 1713605 - Use NSS only on socket thread in CertVerifier::VerifySSLServerCert. r=BenC

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Geoff - that patch introduces some leaks. Please see the comments I left on the phabricator revision.

Comment 4

[Geoff Lankow (:darktrojan)]

Thanks for checking. This is what happens when you get me writing C++ code to fix the build. :-)

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1730798 follow-up - Stop leaking CERTCertificates. r=benc

Comment 6

[Ben Campbell]

(In reply to Dana Keeler (she/her) (use needinfo) (:keeler for reviews) from comment #3)

Geoff - that patch introduces some leaks. Please see the comments I left on the phabricator revision.

Whoops, that was my review, so thanks Dana! The idl getCert() definition confused me. I'm glad someone knows what they're doing :-)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dbe181b3fcb2
follow-up - Stop leaking CERTCertificates. r=benc