Closed Bug 1731016 Opened 3 years ago Closed 3 months ago

Update geckodriver and deps to Rust 2021

Categories

(Testing :: geckodriver, task, P3)

Default
task

Tracking

(firefox121 fixed)

RESOLVED FIXED
121 Branch
Tracking Status
firefox121 --- fixed

People

(Reporter: whimboo, Assigned: rzvncj, Mentored)

References

()

Details

(Whiteboard: [webdriver:m9][webdriver:external][lang=rust])

Attachments

(6 files)

Similar for the 2018 edition (bug 1613975) we should prepare geckodriver for the 2021 Rust edition.

James, when is a good time to get started? Is it after the release as estimated in October?

Folders involved for this transition are:

Flags: needinfo?(james)

We need to wait for Firefox's rust toolchain to update to a release containing the new edition. I think this is going to end up bumping the minimum supported rust version, which could be a problem for people making custom geckodriver builds, so I don't think we want to rush these changes for no reason. But in general I think our policy is to match Firefox.

Practically, I doubt any of the changes are going to be a significant problem for us, so I imagine we'll just run the update tooling and take any suggestions. There's some chance that we'll want to make manual fixups, but nothing jumps out.

Flags: needinfo?(james)

Ok, so lets do it for the 0.32.0 release then.

Blocks: 1750691
Priority: -- → P3
Whiteboard: [webdriver:backlog]
Severity: normal → S3
Mentor: hskupin
Whiteboard: [webdriver:backlog] → [webdriver:backlog][lang=rust]
Assignee: nobody → rzvncj
Status: NEW → ASSIGNED

Depends on D193685

Depends on D193686

Depends on D193687

Depends on D193689

Depends on D193690

cargo fix --edition had nothing to report, so unless I'm missing something it looks like this change is trivial.

FWIW, I've just started this try push.

Looks like that this time we indeed don't have to change any code to be compatible. That means it looks great. Thanks for the patches!

Whiteboard: [webdriver:backlog][lang=rust] → [webdriver:m9][webdriver:external][lang=rust]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2bdad7ccc015
Mark geckodriver as Rust 2021. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/076da8eb1e61
Mark webdriver as Rust 2021. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/cf59875851f5
Mark mozdevice as Rust 2021. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/b1db835a8de7
Mark mozprofile as Rust 2021. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/13a69794839c
Mark mozrunner as Rust 2021. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/ff5810792fa5
Mark mozversion as Rust 2021. r=whimboo,webdriver-reviewers

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #11)

Looks like that this time we indeed don't have to change any code to be compatible. That means it looks great. Thanks for the patches!

Happy to help, thanks for suggesting the issue to work on!

You need to log in before you can comment on or make changes to this bug.