1731016 - Update geckodriver and deps to Rust 2021

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Similar for the 2018 edition (bug 1613975) we should prepare geckodriver for the 2021 Rust edition.

James, when is a good time to get started? Is it after the release as estimated in October?

Folders involved for this transition are:

• https://searchfox.org/mozilla-central/source/testing/geckodriver/
• https://searchfox.org/mozilla-central/source/testing/mozbase/rust/
• https://searchfox.org/mozilla-central/source/testing/webdriver/

Comment 1

[James Graham [:jgraham]]

We need to wait for Firefox's rust toolchain to update to a release containing the new edition. I think this is going to end up bumping the minimum supported rust version, which could be a problem for people making custom geckodriver builds, so I don't think we want to rush these changes for no reason. But in general I think our policy is to match Firefox.

Practically, I doubt any of the changes are going to be a significant problem for us, so I imagine we'll just run the update tooling and take any suggestions. There's some chance that we'll want to make manual fixups, but nothing jumps out.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, so lets do it for the 0.32.0 release then.

Comment 3

[Razvan Cojocaru]

Attachment: Bug 1731016 - Mark geckodriver as Rust 2021. r?whimboo

Comment 4

[Razvan Cojocaru]

Attachment: Bug 1731016 - Mark webdriver as Rust 2021. r?whimboo

Depends on D193685

Comment 5

[Razvan Cojocaru]

Attachment: Bug 1731016 - Mark mozdevice as Rust 2021. r?whimboo

Depends on D193686

Comment 6

[Razvan Cojocaru]

Attachment: Bug 1731016 - Mark mozprofile as Rust 2021. r?whimboo

Depends on D193687

Comment 7

[Razvan Cojocaru]

Attachment: Bug 1731016 - Mark mozrunner as Rust 2021. r?whimboo

Depends on D193689

Comment 8

[Razvan Cojocaru]

Attachment: Bug 1731016 - Mark mozversion as Rust 2021. r?whimboo

Depends on D193690

Comment 9

[Razvan Cojocaru]

cargo fix --edition had nothing to report, so unless I'm missing something it looks like this change is trivial.

Comment 10

[Razvan Cojocaru]

FWIW, I've just started this try push.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks like that this time we indeed don't have to change any code to be compatible. That means it looks great. Thanks for the patches!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bdad7ccc015
Mark geckodriver as Rust 2021. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/076da8eb1e61
Mark webdriver as Rust 2021. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/cf59875851f5
Mark mozdevice as Rust 2021. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/b1db835a8de7
Mark mozprofile as Rust 2021. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/13a69794839c
Mark mozrunner as Rust 2021. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/ff5810792fa5
Mark mozversion as Rust 2021. r=whimboo,webdriver-reviewers

Comment 13

[Razvan Cojocaru]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #11)

Looks like that this time we indeed don't have to change any code to be compatible. That means it looks great. Thanks for the patches!

Happy to help, thanks for suggesting the issue to work on!

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2bdad7ccc015
https://hg.mozilla.org/mozilla-central/rev/076da8eb1e61
https://hg.mozilla.org/mozilla-central/rev/cf59875851f5
https://hg.mozilla.org/mozilla-central/rev/b1db835a8de7
https://hg.mozilla.org/mozilla-central/rev/13a69794839c
https://hg.mozilla.org/mozilla-central/rev/ff5810792fa5