1750691 - Release geckodriver 0.32.0

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P1)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Here the code related changes for all the crates:

mozdevice

➜ hg log -M -r 0545ca5e2e33::central --template "{node|short}\t{desc|firstline}\n" testing/mozbase/rust/mozdevice
None

mozprofile

➜ hg log -M -r 0545ca5e2e33::central --template "{node|short}\t{desc|firstline}\n" testing/mozbase/rust/mozprofile
b398b0763482 Bug 1766125 - Allow setting profile creation directory for geckodriver, r=webdriver-reviewers,whimboo

mozrunner

➜ hg log -M -r 0545ca5e2e33::central --template "{node|short}\t{desc|firstline}\n" testing/mozbase/rust/mozrunner
9d256bc194e7 Bug 1770894 - Update plist to 1.2.1. r=webdriver-reviewers,jgraham
dba435b6010c Bug 1772967 - Update dirs crate to 4.0. r=webdriver-reviewers,gfx-reviewers,jrmuizel,whimboo
93e827afaac1 Bug 1769991 - Change the default firefox binary path when geckodriver is used from within snap confinement r=webdriver-reviewers,jgraham,whimboo

mozversion

➜ hg log -M -r 0545ca5e2e33::central --template "{node|short}\t{desc|firstline}\n" testing/mozbase/rust/mozversion
f52e2ad948e8 Bug 1772048 - Update rustc_version and semver crates. r=emilio,webdriver-reviewers,kinetik,whimboo

webdriver

➜ hg log -M -r 0545ca5e2e33::central --template "{node|short}\t{desc|firstline}\n" testing/webdriver
e98a4c114bee Bug 1710421 - [webdriver] Update time and cookie dependencies. r=webdriver-reviewers,glandium,whimboo
367918ba3373 Bug 1710421 - [webdriver] Update warp and hyper dependencies. r=mjf,webdriver-reviewers
06fd001b4785 Bug 1710421 - Bustage fix. CLOSED TREE
804d4cc1ed37 Bug 1772960 - Upgrade geckodriver to base64 0.13. r=webdriver-reviewers,whimboo
ac440afe7375 Bug 1773265 - Update pointer input support in webdriver crate, r=webdriver-reviewers,whimboo
8f2c396c0d10 Bug 1776264 - [webdriver] Release version 0.46.0. r=webdriver-reviewers,jgraham
22296ec54ef5 Bug 1746601 - Implement wheel input support in marionette, r=webdriver-reviewers,jdescottes
2df6d549261a Bug 1781066 - Disallow missing pointerMove / wheel scroll coordinates, r=webdriver-reviewers,whimboo

marionette

➜ hg log -M -r 0545ca5e2e33::central --template "{node|short}\t{desc|firstline}\n" testing/geckodriver/marionette
None

geckodriver

➜ hg log -M -r 0545ca5e2e33::central --template "{node|short}\t{desc|firstline}\n" testing/geckodriver/src
b398b0763482 Bug 1766125 - Allow setting profile creation directory for geckodriver, r=webdriver-reviewers,whimboo
9e9d38276a76 Bug 1770072 - Upgrade geckodriver to clap 3.1. r=webdriver-reviewers,jgraham
43c4718b8847 Bug 1775036 - [geckodriver] Remove unused code for chrome element references. r=webdriver-reviewers,jgraham
dc056cec8e3e Bug 1757721 - [geckodriver] Also restore backup of prefs.js for Remote Browser. r=webdriver-reviewers,jgraham
4e5ff4cd430a Bug 1793786 - Update Glean version to 51.4.0 r=chutten,supply-chain-reviewers,webdriver-reviewers

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1750691 - [rust-mozprofile] Release and cargo vet version 0.9.0.

Depends on D159030

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1750691 - [rust-mozrunner] Release and cargo vet version 0.15.0

Depends on D159152

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1750691 - [rust-mozversion] Release version 0.5.0

Depends on D159153

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1750691 - [webdriver] Release version 0.47.0

Depends on D159154

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1750691 - [geckodriver] Update changeset for the 0.32.0 release.

Depends on D159156

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1750691 - [geckodriver] Release version 0.32.0.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8f8bd544a61
[rust-mozprofile] Release and cargo vet version 0.9.0. r=webdriver-reviewers,jgraham,supply-chain-reviewers,bholley
https://hg.mozilla.org/integration/autoland/rev/b5fae6fdf9f6
[rust-mozrunner] Release and cargo vet version 0.15.0 r=webdriver-reviewers,jgraham,supply-chain-reviewers,bholley
https://hg.mozilla.org/integration/autoland/rev/d855510d971c
[rust-mozversion] Release version 0.5.0 r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/75343e824a11
[webdriver] Release version 0.47.0 r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/e87a1a8aed68
[geckodriver] Release version 0.32.0. r=webdriver-reviewers,jgraham

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d8f8bd544a61
https://hg.mozilla.org/mozilla-central/rev/b5fae6fdf9f6
https://hg.mozilla.org/mozilla-central/rev/d855510d971c
https://hg.mozilla.org/mozilla-central/rev/75343e824a11
https://hg.mozilla.org/mozilla-central/rev/e87a1a8aed68

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The release is not done. Will have to wait for the next nightly builds before continuing with the release process.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The merge commit for this release is:
https://treeherder.mozilla.org/jobs?repo=mozilla-central&searchStr=geckodriver&revision=4563dd583110be33b4767284f04e1ea83f1a78bc

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92a7c3425d17
[geckodriver] Update changeset for the 0.32.0 release. r=webdriver-reviewers,jgraham DONTBUILD

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Publishing crates to crates.io:

Uploading mozprofile v0.9.0
Uploading mozrunner v0.15.0
Uploading mozversion v0.5.0
Uploading webdriver v0.47.0
Uploading geckodriver v0.32.0

Release of geckodriver 0.32.0:
https://github.com/mozilla/geckodriver/releases/tag/v0.32.0

I noticed that we forgot to mention the new aarch64 binaries for Linux and Windows in the changes log. I'll follow up with a small additional revision.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1750691 - [geckodriver] Added missing 0.32.0 release changes.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1750691 - [geckodriver] Update releasing documentation.

Depends on D159328

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I've announced the release on the mailing list:
https://groups.google.com/a/mozilla.org/g/dev-webdriver/c/EXVeeqHxEM4

I'm going to leave the bug open until we landed all the patches.

Comment 17

[az [:az]]

I'm running into the following error running ./mach vendor rust, which looks related:

0:04.00 Vet error: There are some issues with your policy.audit-as-crates-io entries
0:04.00  related error: Some non-crates.io-fetched packages match published crates.io versions
  mozversion:0.5.0

Running ./mach cargo vet returns:

$ ./mach cargo vet
ERROR 
  × There are some issues with your policy.audit-as-crates-io entries

Error: 
  × Some non-crates.io-fetched packages match published crates.io versions
  │   mozversion:0.5.0
  help: Add a `policy.*.audit-as-crates-io` entry for them

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/92a7c3425d17

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to az [:az] from comment #17)

I'm running into the following error running ./mach vendor rust, which looks related:

0:04.00 Vet error: There are some issues with your policy.audit-as-crates-io entries
0:04.00  related error: Some non-crates.io-fetched packages match published crates.io versions
  mozversion:0.5.0

Running ./mach cargo vet returns:

$ ./mach cargo vet
ERROR 
  × There are some issues with your policy.audit-as-crates-io entries

Error: 
  × Some non-crates.io-fetched packages match published crates.io versions
  │   mozversion:0.5.0
  help: Add a `policy.*.audit-as-crates-io` entry for them

That's strange. That wasn't present before. Maybe it was caused by publishing the new crates?

The mozversion is not vetted yet but even when I do there is a strange change which doesn't match at all and removes the entry from mozrunner.

-[[audits.mozrunner]]
+[[audits.version]]
 who = "Henrik Skupin <[e-mail]>"
 criteria = "safe-to-deploy"
-version = "0.15.0"
+version = "0.5.0"
 notes = "Maintained by the DevTools team at Mozilla and has no unsafe code."

I don't know what's wrong here. Bobby or Mike could you help with that?

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mike helped me on Element and I have a patch soon.

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1750691 - [rust-mozversion] Cargo vet version 0.5.0.

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #19)

The mozversion is not vetted yet but even when I do there is a strange change which doesn't match at all and removes the entry from mozrunner.

-[[audits.mozrunner]]
+[[audits.version]]
 who = "Henrik Skupin <[e-mail]>"
 criteria = "safe-to-deploy"
-version = "0.15.0"
+version = "0.5.0"
 notes = "Maintained by the DevTools team at Mozilla and has no unsafe code."

I don't know what's wrong here. Bobby or Mike could you help with that?

It's still strange why mozversion wasn't listed yet and when vetting this crate the existing entry for mozrunner is modified with a name that is not even related to mozversion. Bobby, is that a bug in the vetting code?

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b439d62cd568
[geckodriver] Added missing 0.32.0 release changes. r=webdriver-reviewers,jdescottes DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/090b88ecb8ff
[geckodriver] Update releasing documentation. r=webdriver-reviewers,jdescottes DONTBUILD

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d2a13920841
[rust-mozversion] Cargo vet version 0.5.0. r=supply-chain-reviewers,bholley

Comment 25

[Bobby Holley (:bholley)]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] (away 10/17 - 10/20) from comment #22)

It's still strange why mozversion wasn't listed yet and when vetting this crate the existing entry for mozrunner is modified with a name that is not even related to mozversion. Bobby, is that a bug in the vetting code?

Yes, this appears to be a bug: https://github.com/mozilla/cargo-vet/pull/340

Comment 26

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b439d62cd568
https://hg.mozilla.org/mozilla-central/rev/090b88ecb8ff
https://hg.mozilla.org/mozilla-central/rev/9d2a13920841