Closed Bug 1731058 Opened 4 years ago Closed 4 years ago

Intermittent browser/components/urlbar/tests/browser/browser_quicksuggest_onboardingDialog.js | After filtering we must have the expected number of events. - 3 == 1 - JS frame :: resource://testing-common/TelemetryTestUtils.jsm :: assertEvents :: line 182

Categories

(Firefox :: Address Bar, defect, P5)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Iteration:
95.1 - Oct 4 - Oct 17
Tracking Flags:
Tracking Status
firefox94 --- fixed
firefox95 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: adw)

References

Details

(Keywords: intermittent-failure, Whiteboard: [fixed by bug 1733687])

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=351714935&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IrQry0vGQd24FEk0uFQQPQ/runs/0/artifacts/public/logs/live_backing.log

INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_quicksuggest_onboardingDialog.js | parent must be in snapshot. Has [parent]. - true == true - 
[task 2021-09-16T10:26:18.358Z] 10:26:18     INFO - Buffered messages finished
[task 2021-09-16T10:26:18.360Z] 10:26:18     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_quicksuggest_onboardingDialog.js | After filtering we must have the expected number of events. - 3 == 1 - JS frame :: resource://testing-common/TelemetryTestUtils.jsm :: assertEvents :: line 182
[task 2021-09-16T10:26:18.360Z] 10:26:18     INFO - Stack trace:
[task 2021-09-16T10:26:18.360Z] 10:26:18     INFO - resource://testing-common/TelemetryTestUtils.jsm:assertEvents:182
[task 2021-09-16T10:26:18.360Z] 10:26:18     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_quicksuggest_onboardingDialog.js:doDialogTest/<:400
[task 2021-09-16T10:26:18.362Z] 10:26:18     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_quicksuggest_onboardingDialog.js

According to the log it's a failure in the new focus_settings task added in bug 1730691. I don't see why there would be 3 events instead of only the one. doDialogTest clears telemetry events before the focus_settings callback is called.

There's a strange console message after that task starts:

[task 2021-09-16T10:26:18.351Z] 10:26:18 INFO - Console message: Invalid chrome URI (need path): chrome://browser/

It's got to be related to the task -- it seems really unlikely Firefox is trying to use (load?) some random URI right then. But the dialog opens successfully because there are test passes after that. This error also appears for like every task before that too, so it's probably a red herring?

Blocks: 1730691
status-firefox94: --- → affected

My patch in bug 1733687 fixes this. There are some stray events related to remote settings. We just need to filter on the contextual services category.

Depends on: 1733687

This should be fixed on m-c now.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 1733687]
Assignee: nobody → adw
Iteration: --- → 95.1 - Oct 4 - Oct 17
Points: --- → 1
status-firefox94: affected → fixed
status-firefox95: --- → fixed
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.