1730691 - The “Learn more” and “Not now“ Firefox Suggest modal links are not keyboard selectable

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: links not selectable.gif

[Affected Versions]:

• FIrefox Beta 93.0b4 (Build ID: 20210912185727)
• Firefox Nightly 94.0a1 (Build ID: 20210913213224)

[Affected Platforms]:

• Windows 10
• Linux Mint 20
• macOS 11.1

[Prerequisites]:

• Have Firefox installed and opened.
• Have the following preferences set:
  • browser.urlbar.quicksuggest.enabled = true
  • browser.urlbar.quicksuggest.scenario = online
  • browser.urlbar.quicksuggest.shouldShowOnboardingDialog = true
  • browser.urlbar.suggest.quicksuggest = false
  • browser.urlbar.suggest.quicksuggest.sponsored = false

[Steps to reproduce]:

1. Restart the browser after setting prerequisite preferences.
2. Dismiss the Make Firefox default message if it is displayed to trigger the Suggestions modal.
3. Use the Tab or arrow keys to try and select “Learn more”.
4. Use the Tab or arrow keys to try and select “Not now”.

[Expected result]:

• “Learn more” and “Not now” are keyboard selectable.

[Actual result]:

• “Learn more” and “Not now” can not be selected.

[Notes]:

• There is a state where nothing seems selected, but pressing Enter will close the modal and the functionality will be as if “Allow suggestions” was chosen.
• Attached is a screen recording of the issue.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1730691 - Properly support tabbing through the elements in the Firefox Suggest onboarding dialog.

Give tabindex attributes to each focusable element and handle enter keypresses
(via the dialogaccept event) on them. The tab index ordering is:

1. Accept button (initial focus)
2. Settings button
3. Learn more
4. Not now

Also give #infoBody a tab index of -1 so it doesn't receive focus. It does
normally for some reason.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9148cfa438b9cfe813b711ba4d39ff8897e1a0d

Comment 3

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6146770f43152005bef6397882a82fccd35cf79f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f88af07990e38106ae56a0cbeefaff687d921960

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5456abe4535
Properly support tabbing through the elements in the Firefox Suggest onboarding dialog. r=dao

Comment 5

[Drew Willcoxon :adw]

For verification, please note that the arrow keys still don't work very well. There's not much we can do about it, so we'll have to live with it.

The tab key should properly move the focus through the controls, however. (You probably know already but on macOS you have to go to the Shortcuts tab of the Keyboard pane in System Preferences and enable "Use keyboard navigation to move focus between controls")

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b5456abe4535

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 9241243 [details]
Bug 1730691 - Properly support tabbing through the elements in the Firefox Suggest onboarding dialog.

Beta/Release Uplift Approval Request

• User impact if declined: Needed for important Firefox Suggest rollouts on 93 and 92
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from comment 0; please see also comment 5
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch affects only the FIrefox Suggest online onboarding dialog, which will only be shown to users in the US who are enrolled in the online rollout.
• String changes made/needed:

Comment 8

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the issue is no longer reproducible on Firefox 94. "Learn more" and "Not now" can now be selected using the Tab key (and sometimes the arrow keys). Tested using Firefox Nightly 94.0a1 (Build ID: 20210916125444) on Windows 10, macOS 11.1 and Linux Mint 20.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9241243 [details]
Bug 1730691 - Properly support tabbing through the elements in the Firefox Suggest onboarding dialog.

Needed for experiments targeting Fx92. Approved for 93.0b6.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3c937a58b742

Comment 11

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the issue is no longer reproducible on Firefox 93. "Learn more" and "Not now" can now be selected using the Tab key. Tested using Firefox Beta 93.0b6 (Build ID: 20210916185649) on Windows 10, macOS 11.1 and Linux Mint 20.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9241243 [details]
Bug 1730691 - Properly support tabbing through the elements in the Firefox Suggest onboarding dialog.

Approved for 92.0.1.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/84423b0efd4e

Comment 14

[Carmen Fat [:cfat] - Ecosystem QA]

• I have verified this issue using the Candidate 92.0.1 build (Build ID: 20210920202613) on Windows 10 x64, macOS 10.15.7 and Linux Ubuntu 20.04 x64.

• The "Learn more" and "Not now" can now be selected using the Tab key (and sometimes the arrow keys).