1731497 - Cannot close tab with middle mouse button click

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect, P4)

Description

[mozbugz]

Closing a tab with middle mouse button click does not work.

E.g. open a PDF attachment with integrated viewer and try to close the PDF tab with middle mouse button click on the tab.

Comment 1

[Thomas D. (:thomas8)]

Thanks mozbugz! Indeed.

regressionwindow - Alice, would you?

Confirming 94.0a1 (2021-09-19) (64-bit), Win10. Middle-button click on tab does nothing.
Also broken on 93.0b2 (64-bit).
Still working on 91.1.1 (64-bit).

Comment 2

[Thomas D. (:thomas8)]

.

Comment 3

[WaltS48 [:walts48]]

I also see this with 93.0b2 and 94.0a1 on Fedora 34 Workstation Linux. (64-bit)

Comment 4

[Alice0775 White]

Rehression windpw:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=000dd197a381fed989417cd45ae7d25cfd3be53c&tochange=99166a3245724c3188ebd041d0b13c3b691fdfac
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6c984a259bdc8d11cb4fe887b9ae2c6add2545e5&tochange=e84a121c42cbc3d6882ccd7c2341aa31eecdc05f

Comment 5

[juraj.masiar]

Still broken in 93.0b4. The error in the console:

 Uncaught TypeError: document.tab is undefined
    onTabClick chrome://messenger/content/tabmail.js:1724
    onclick chrome://messenger/content/messenger.xhtml:1

In the code:

    onTabClick(event) {
      // a middle mouse button click on a tab is a short cut for closing a tab
      if (event.button != 1 || document.tab.localName != "tab") {

Also, why are you not using !==? Even without a linter my IDE would still complain about not strict equality! And seeing let everywhere :(...
Please excuse my negative comments, it's a professional deformation finding issues in other people code :)

Comment 6

[Alice0775 White]

Definition of document.tab was removed by patch( https://hg.mozilla.org/comm-central/rev/c6695c5b570849c35824313a34abe6dc6f44160c#l4.62 ) of Bug 1683865.

Comment 7

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1731497 - Fix closing tabs issues introduced by rev c6695c5b5708. r=mkmelin

Restored:

• Middle mouse click on a tab closes it.
• Prevent switching to a tab before closing it when the tab's close button is clicked.

Comment 8

[Henry Wilkes (they/them) [:henry-x]]

Try run for the new test https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=1f0cb9926c6d7ec8cd5011e0753c412c309bb1e2

With fix for macosx https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=eb97f79e7069ee07fceebd6b8b803669343d1ea2

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a5a2b7acbee1
Fix closing tabs issues introduced by rev c6695c5b5708. r=mkmelin