Closed Bug 1731497 Opened 1 year ago Closed 1 year ago

Cannot close tab with middle mouse button click

Categories

(Thunderbird :: Toolbars and Tabs, defect, P4)

All
Windows 10

Tracking

(thunderbird_esr91 unaffected, thunderbird93 affected)

RESOLVED FIXED
94 Branch
Tracking Status
thunderbird_esr91 --- unaffected
thunderbird93 --- affected

People

(Reporter: bugsgalore, Assigned: henry-x)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(1 file)

Closing a tab with middle mouse button click does not work.

E.g. open a PDF attachment with integrated viewer and try to close the PDF tab with middle mouse button click on the tab.

Thanks mozbugz! Indeed.

regressionwindow - Alice, would you?

Confirming 94.0a1 (2021-09-19) (64-bit), Win10. Middle-button click on tab does nothing.
Also broken on 93.0b2 (64-bit).
Still working on 91.1.1 (64-bit).

Flags: needinfo?(alice0775)

.

Severity: -- → S3
Status: UNCONFIRMED → NEW
Component: Untriaged → Toolbars and Tabs
Ever confirmed: true
Priority: -- → P4
Hardware: x86_64 → All

I also see this with 93.0b2 and 94.0a1 on Fedora 34 Workstation Linux. (64-bit)

Still broken in 93.0b4. The error in the console:

 Uncaught TypeError: document.tab is undefined
    onTabClick chrome://messenger/content/tabmail.js:1724
    onclick chrome://messenger/content/messenger.xhtml:1

In the code:

    onTabClick(event) {
      // a middle mouse button click on a tab is a short cut for closing a tab
      if (event.button != 1 || document.tab.localName != "tab") {

Also, why are you not using !==? Even without a linter my IDE would still complain about not strict equality! And seeing let everywhere :(...
Please excuse my negative comments, it's a professional deformation finding issues in other people code :)

Regressed by: 1683865
Assignee: nobody → henry

Restored:

  • Middle mouse click on a tab closes it.
  • Prevent switching to a tab before closing it when the tab's close button is clicked.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/a5a2b7acbee1
Fix closing tabs issues introduced by rev c6695c5b5708. r=mkmelin

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
See Also: → 1734413
You need to log in before you can comment on or make changes to this bug.