1731707 - [rust 1.56] error: unreachable expression in wrench/src/main.rs

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mike Hommey [:glandium]]

[task 2021-09-21T02:00:52.129Z] error: unreachable expression
[task 2021-09-21T02:00:52.129Z]    --> wrench/src/main.rs:350:21
[task 2021-09-21T02:00:52.129Z]     |
[task 2021-09-21T02:00:52.129Z] 345 |                   let (_window, _context) = angle::Context::with_window(
[task 2021-09-21T02:00:52.129Z]     |  ___________________________________________-
[task 2021-09-21T02:00:52.129Z] 346 | |                     window_builder, context_builder, events_loop
[task 2021-09-21T02:00:52.129Z] 347 | |                 ).unwrap();
[task 2021-09-21T02:00:52.129Z]     | |__________________________- any code following this expression is unreachable
[task 2021-09-21T02:00:52.129Z] ...
[task 2021-09-21T02:00:52.129Z] 350 |                       _context
[task 2021-09-21T02:00:52.129Z]     |                       ^^^^^^^^ unreachable expression
[task 2021-09-21T02:00:52.129Z]     |
[task 2021-09-21T02:00:52.129Z]     = note: `-D unreachable-code` implied by `-D warnings`
[task 2021-09-21T02:00:52.129Z] note: this expression has type `(glutin::Window, angle::Context)`, which is uninhabited
[task 2021-09-21T02:00:52.129Z]    --> wrench/src/main.rs:345:43
[task 2021-09-21T02:00:52.129Z]     |
[task 2021-09-21T02:00:52.129Z] 345 |                   let (_window, _context) = angle::Context::with_window(
[task 2021-09-21T02:00:52.129Z]     |  ___________________________________________^
[task 2021-09-21T02:00:52.129Z] 346 | |                     window_builder, context_builder, events_loop
[task 2021-09-21T02:00:52.129Z] 347 | |                 ).unwrap();
[task 2021-09-21T02:00:52.129Z]     | |__________________________^
[task 2021-09-21T02:00:52.129Z] 
[task 2021-09-21T02:00:52.498Z] error: could not compile `wrench` due to previous error

It looks like rust 1.56 now finds out that andle::Context::with_windows(...).unwrap() is always panicking on non-windows.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1731707 - Work around rust >= 1.56 finding unreachable code on non-windows.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f66a5b3d911a
Work around rust >= 1.56 finding unreachable code on non-windows. r=gfx-reviewers,jrmuizel

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f66a5b3d911a