Closed Bug 1731730 Opened 3 years ago Closed 1 year ago

Implement capability matching for features for the session.new command

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

task
Points:
5

Tracking

(firefox116 fixed)

RESOLVED FIXED
116 Branch
Tracking Status
firefox116 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 4 open bugs, )

Details

(Whiteboard: [webdriver:m7], [wptsync upstream][webdriver:relnote])

Attachments

(3 files)

For direct BiDi connections that make use of the session.new command we need WebDriver's capability matching implemented. Right now it's only present in the Rust implementation for webdriver, and handles the WebDriver HTTP case.

It also has to incorporate the changes as upcoming via https://github.com/w3c/webdriver/pull/1608.

Points: --- → 8
Priority: -- → P3
Priority: P3 → --
Whiteboard: [bidi-m2-mvp] → [bidi-m3-mvp]

Lets actually remove it from M3 because it's not related to navigation. We will come back to it once we have requirements for allowing WebDriver BiDi clients to directly connect.

Priority: -- → P3
Whiteboard: [bidi-m3-mvp]
Whiteboard: [webdriver:backlog]

As discussed we should for now focus on the features and not so much on the browser / platform matching. As such this bug will cover the following scenarios that need to be handled correctly:

Global defined features:

  • acceptInsecureCerts
  • proxy
  • strictFileInteractability (not sure yet if that would be needed)

Mozilla specific features:

  • moz:accessibilityChecks
  • moz:windowless

We should actually re-use the Capabilities.sys.mjs module here and send a full capability payload back to the client. Maybe an update of the WebDriver classic spec is needed if not all the capabilities can / should be returned via WebDriver BiDi.

Summary: Implement capability matching for session.new command → Implement capability matching for features for the session.new command
Points: 8 → 5
Priority: P3 → P1
Whiteboard: [webdriver:backlog] → [webdriver:m7]
Priority: P1 → P2
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Blocks: 1833636
Attachment #9335175 - Attachment description: WIP: Bug 1731730 - [bidi] Implement capability matching for features for the session.new command. → Bug 1731730 - [bidi] Implement capability matching for features for the session.new command.
Attachment #9335176 - Attachment description: WIP: Bug 1731730 - [wdspec] Update session.new command in bidi test client. → Bug 1731730 - [wdspec] Update session.new command in bidi test client.
Attachment #9335177 - Attachment description: WIP: Bug 1731730 - Add gecko specific tests for session.new command. → Bug 1731730 - Add gecko specific tests for session.new command.
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4e5f80c6793
[bidi] Implement capability matching for features for the session.new command. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/b7ccdf57f5aa
[wdspec] Update session.new command in bidi test client. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/7d1262df9498
Add gecko specific tests for session.new command. r=webdriver-reviewers,jdescottes,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40444 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m7] → [webdriver:m7], [wptsync upstream]
Upstream PR was closed without merging
Flags: needinfo?(aborovova)
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/982b9ea49102
[bidi] Implement capability matching for features for the session.new command. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/43765d28bc7b
[wdspec] Update session.new command in bidi test client. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/7dcccba7de5e
Add gecko specific tests for session.new command. r=webdriver-reviewers,jdescottes,whimboo
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m7], [wptsync upstream] → [webdriver:m7], [wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: