1731730 - Implement capability matching for features for the session.new command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For direct BiDi connections that make use of the session.new command we need WebDriver's capability matching implemented. Right now it's only present in the Rust implementation for webdriver, and handles the WebDriver HTTP case.

It also has to incorporate the changes as upcoming via https://github.com/w3c/webdriver/pull/1608.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Lets actually remove it from M3 because it's not related to navigation. We will come back to it once we have requirements for allowing WebDriver BiDi clients to directly connect.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As discussed we should for now focus on the features and not so much on the browser / platform matching. As such this bug will cover the following scenarios that need to be handled correctly:

Global defined features:

• acceptInsecureCerts
• proxy
• strictFileInteractability (not sure yet if that would be needed)

Mozilla specific features:

• moz:accessibilityChecks
• moz:windowless

We should actually re-use the Capabilities.sys.mjs module here and send a full capability payload back to the client. Maybe an update of the WebDriver classic spec is needed if not all the capabilities can / should be returned via WebDriver BiDi.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1731730 - [bidi] Implement capability matching for features for the session.new command.

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1731730 - [wdspec] Update session.new command in bidi test client.

Depends on D178619

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1731730 - Add gecko specific tests for session.new command.

Depends on D178620

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4e5f80c6793
[bidi] Implement capability matching for features for the session.new command. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/b7ccdf57f5aa
[wdspec] Update session.new command in bidi test client. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/7d1262df9498
Add gecko specific tests for session.new command. r=webdriver-reviewers,jdescottes,whimboo

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40444 for changes under testing/web-platform/tests

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for Btime failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/822630f92d8682bece67b5e51ae9e18c8c8af79f
Log link: https://treeherder.mozilla.org/logviewer?job_id=418608700&repo=autoland&lineNumber=1200

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/982b9ea49102
[bidi] Implement capability matching for features for the session.new command. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/43765d28bc7b
[wdspec] Update session.new command in bidi test client. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/7dcccba7de5e
Add gecko specific tests for session.new command. r=webdriver-reviewers,jdescottes,whimboo

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/982b9ea49102
https://hg.mozilla.org/mozilla-central/rev/43765d28bc7b
https://hg.mozilla.org/mozilla-central/rev/7dcccba7de5e

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot