1771760 - Non-spec capability "platformVersion" gets returned - needs to be a vendor prefixed one

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Originally reported as: https://github.com/mozilla/geckodriver/issues/2023

We inappropriately return the platformVersion capability, which is not part of the WebDriver specification and as such needs to be vendor prefixed.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The related capability that needs a change can be found here:
https://searchfox.org/mozilla-central/rev/28ed523a3ed5dbf5f6b008cf1e28a9e8a8597b5e/remote/shared/webdriver/Capabilities.jsm#439

To get this fixed the capability needs to be renamed to moz:platformVersion.

Note that this would also require changes to at least the following unit tests for Marionette:
https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_capabilities.py
https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_session.py

Comment 2

[Salil Mishra [:naming_is_hard]]

Hey! I would like to work on this bug. I have the code ready, just facing some problems to sending it for review.

Comment 3

[Salil Mishra [:naming_is_hard]]

Attachment: Bug 1771760 - [marionette] Rename vendor specific capability `platformVersion` to `moz:platformVersion`

platformVersion capability is not part of the WebDriver specification and needs to be vendor prefixed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/36cc01aea9bb
[marionette] Rename vendor specific capability `platformVersion` to `moz:platformVersion` r=whimboo,webdriver-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/36cc01aea9bb