1731990 - Make the Service Worker to use foreignPartitionedPrinicpal for registration, intercept channels and spawning workers in dFPI

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[Tim Huang[:timhuang]]

To partition Service Worker, it has to use the partitionPrincipal to do the registration and spawning workers.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1731990 - Part 1: Using ForeignPartitionedPrincipal in ServiceWorkerInterceptController. r?asuth

This patch changes to use the foreign partitioned principal when check
if a channel needs to be intercepted by a certain service worker.

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1731990 - Part 2: Using foreignPartitionedPrincipal in ServiceWorkerContainer. r?asuth

The patch modifies ServiceWorkerContainer::GetScopeForUrl() to use the
foreign partitioned principal.

Depends on D128731

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1731990 - Part 3: Use the partitionKey from the foreign partitioned principal in ServiceWorkerPrivate. r?asuth,pbz

We used to use the principal URL for the partitionKey in
ServiceWorkerPrivateImpl. This is correct if the ServiceWorker only
works in first-party context. But, it isn't correct in third-party
context.

To fix that, we can directly use the foreign paritioned principal from
the ServiceWorkerPrivate to get the partitionKey in third-party context.
For the first-party context, we can still use the original approach to
get the partitionKey.

Depends on D128732

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug 1731990 - Part 4: Populate the partitionKey from the prinicpal of the service worker in ServiceWorkerScriptCache. r?asuth

This patch changes ServiceWorkerScriptCache to use the principal of the
service worker to populate the partitionKey to the cookieJarSettings.
The service workers are using foreign partitioned principal. This means
it will contain a correct partitionKey if it's in a third-party context.
So we can use it to populate the partitionKey. In the first-party
context, we can use the script uri to get the partionKey, which is the
original approach.

Depends on D128733

Comment 5

[Tim Huang[:timhuang]]

Attachment: Bug 1731990 - Part 5: Add tests for partitioned third-party service worker. r?pbz

Depends on D128734

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97d6cf760a47
Part 1: Using ForeignPartitionedPrincipal in ServiceWorkerInterceptController. r=asuth
https://hg.mozilla.org/integration/autoland/rev/738670a0e276
Part 2: Using foreignPartitionedPrincipal in ServiceWorkerContainer. r=asuth
https://hg.mozilla.org/integration/autoland/rev/f023cff11d39
Part 3: Use the partitionKey from the foreign partitioned principal in ServiceWorkerPrivate. r=pbz,dom-storage-reviewers,edenchuang
https://hg.mozilla.org/integration/autoland/rev/c6c7c0aa9519
Part 4: Populate the partitionKey from the prinicpal of the service worker in ServiceWorkerScriptCache. r=asuth
https://hg.mozilla.org/integration/autoland/rev/dd8df905c0a8
Part 5: Add tests for partitioned third-party service worker. r=pbz

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/97d6cf760a47
https://hg.mozilla.org/mozilla-central/rev/738670a0e276
https://hg.mozilla.org/mozilla-central/rev/f023cff11d39
https://hg.mozilla.org/mozilla-central/rev/c6c7c0aa9519
https://hg.mozilla.org/mozilla-central/rev/dd8df905c0a8