1732255 - AttributeError: module 'mozbuild.build_commands' has no attribute '_run_make'

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[:gerard-majax]

Breakage for running clang checks on Phabricator

https://treeherder.mozilla.org/jobs?repo=try&revision=4eabe98c2ffda19e60c2986dccfdeabcc7b1eb5c

task 2021-09-23T08:01:52.046Z] Error running mach:
[task 2021-09-23T08:01:52.046Z] 
[task 2021-09-23T08:01:52.046Z]     ['--log-no-times', 'static-analysis', 'check', '--outgoing', '--output', '/builds/worker/clang-tidy.json', '--format', 'json']
[task 2021-09-23T08:01:52.046Z] 
[task 2021-09-23T08:01:52.046Z] The error occurred in the implementation of the invoked mach command.
[task 2021-09-23T08:01:52.046Z] 
[task 2021-09-23T08:01:52.046Z] This should never occur and is likely a bug in the implementation of that
[task 2021-09-23T08:01:52.046Z] command.
[task 2021-09-23T08:01:52.046Z] You can invoke |./mach busted| to check if this issue is already on file. If it
[task 2021-09-23T08:01:52.046Z] isn't, please use |./mach busted file static-analysis| to report it. If |./mach busted| is
[task 2021-09-23T08:01:52.046Z] misbehaving, you can also inspect the dependencies of bug 1543241.
[task 2021-09-23T08:01:52.046Z] 
[task 2021-09-23T08:01:52.046Z] If filing a bug, please include the full output of mach, including this error
[task 2021-09-23T08:01:52.046Z] message.
[task 2021-09-23T08:01:52.046Z] 
[task 2021-09-23T08:01:52.046Z] The details of the failure are as follows:
[task 2021-09-23T08:01:52.046Z] 
[task 2021-09-23T08:01:52.046Z] AttributeError: module 'mozbuild.build_commands' has no attribute '_run_make'
[task 2021-09-23T08:01:52.046Z] 
[task 2021-09-23T08:01:52.046Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/code_analysis/mach_commands.py", line 328, in check
[task 2021-09-23T08:01:52.047Z]     rc = rc or _build_export(command_context, jobs=jobs, verbose=verbose)
[task 2021-09-23T08:01:52.047Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/code_analysis/mach_commands.py", line 2174, in _build_export
[task 2021-09-23T08:01:52.047Z]     rc = build_commands._run_make(

Comment 1

[Andi [:andi]]

This brakes the static analysis implemented via mach.

Comment 2

[Andreas Farre [:farre]]

I could fix bug 1732216 by just switching build_commands to command_context. I'm guessing it should work here as well, but harder for me to verify.

Comment 3

[Andi [:andi]]

We are going to completely backout: https://hg.mozilla.org/mozilla-central/rev/53b1fa0faa6d78f7cf72f9cbe3dc85221a04eea3

Comment 4

[Andi [:andi]]

The issue that was causing this, https://hg.mozilla.org/mozilla-central/rev/53b1fa0faa6d78f7cf72f9cbe3dc85221a04eea3, has been backed out.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1696251