1732301 - Replace the "Highlight" system color with "SelectedItem"

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

SelectedItem is the new Highlight colour. Highlight is on Linux and Windows more or less the same but macOS uses now a faint highlight colour which makes us to need to switch to SelectedItem.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1732301-Highlight-to-SelectedItem-mail.patch

The mail part.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1732301-Highlight-to-SelectedItem-calendar.patch

And the calendar part.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9242677 [details] [diff] [review]
1732301-Highlight-to-SelectedItem-mail.patch

Review of attachment 9242677 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for going through all of these, great work.

::: mail/themes/shared/mail/glodaFacetView.css
@@ +425,5 @@
>  
>  .results-message-showall-button:hover,
>  .results-message-showall-button:focus {
> +  background-color: SelectedItem;
> +  color: SelectedItemtext;

SelectedItemText with camel case on the T?
Does it change anything? Even if it doesn't we should be consistent about it.

@@ +493,5 @@
>  
>  .message .message-subject:hover,
>  .message .message-subject:focus {
> +  background-color: SelectedItem;
> +  color: SelectedItemtext;

Same here.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9242678 [details] [diff] [review]
1732301-Highlight-to-SelectedItem-calendar.patch

Review of attachment 9242678 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1732301-Highlight-to-SelectedItem-mail.patch

Fixed the camel case.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/722ab6bd89e6
[Calendar] Replace the "Highlight" system color with "SelectedItem". r=aleca
https://hg.mozilla.org/comm-central/rev/3298fc32b9f7
[Mail] Replace the "Highlight" system color with "SelectedItem". r=aleca

Comment 8

[Leo]

will this also fix the issue of the default buttons color that i mentioned in bug: 1733838:

the color of default buttons in dialogs is faint blue instead of real blue

or should i file a separate bug for this?

Comment 9

[Richard Marti (:Paenglab)]

The default buttons are fixed too.