1732382 - Regression: menus and settings are only partially translated in 92.0.1-1 snap

Status: RESOLVED DUPLICATE of bug 1732676

(Toolkit :: Add-ons Manager, defect)

Description

[Olivier Tilloy]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

I am testing the update to 92.0.1-1 as a snap package, in the candidate channel.

Actual results:

The menu is only partially translated to my preferred language (French), some entries are in French as expected (e.g. "Aide" for "Help"), others are in English (e.g. "New tab").

The about:preferences pages are untranslated, but about:addons pages are translated.

Expected results:

Everything should be translated to my preferred language.
This is a regression, version 92.0-3 in the stable channel doesn't exhibit this problem.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Add-ons Manager' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Olivier Tilloy]

A fresh install of the 92.0.1-1 snap with no existing profile (or creating a brand new profile) works correctly, everything is translated.
It's the upgrade path from 92.0-3 to 92.0.1-1 that partially breaks translations.

Comment 3

[Alex Cornestean]

Hello,

I’ve attempted to reproduce the issue you are having but I’m having some trouble with the snap package updating.

When I do “snap info firefox” the only available version for installing is 92.0.1-1 on the candidate channel. So I went ahead and downloaded the 92.0-3 snap version locally, installed it with “sudo snap install --dangerous firefox-92.0.snap” and tried to update it but it failed several times.

Could you please provide some more detailed steps on how to install the 92.0-3 snap version and how o update it? Thank you !

Comment 4

[Olivier Tilloy]

$ snap info firefox
[…]
channels:
  latest/stable:    92.0-3       2021-09-09 (595) 159MB -
  latest/candidate: 92.0.1-1     2021-09-23 (625) 159MB -
[…]

So on a clean system (with a non-English locale), just run snap install firefox to get the version from stable, use it for a while, then close the app and run snap refresh firefox --candidate, launch the app again and observe the problem with menus half-translated.

Comment 5

[Alex Cornestean]

Thank you very much for the info !

I managed to reproduce the issue as per the steps in Comment 4.

I’ve set my locale to de_DE (German) and the snap installed 92.0-3 version from stable had the UI in German (see screenshot).
After updating the browser, some menu entries appeared in English and a few in the original language – German (see screenshot).
about:addons, about:support remained in German, while about:preferences was fully translated to English.

Comment 6

[Alex Cornestean]

Attachment: 92.0-3 german locale.png

Comment 7

[Alex Cornestean]

Attachment: updated 92.0.1-1.png

Comment 8

[Tomislav Jovanovic :zombie]

Possibly related bug 1732676?

Comment 9

[Francesco Lodolo [:flod]]

More probably a dupe of bug 1732506.

What's unclear to me is that Snap packages should ship with their own language packs? If so, they should have the latest language pack (Sep 22), which shouldn't cause the issue.

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #9)

More probably a dupe of bug 1732506.

What's unclear to me is that Snap packages should ship with their own language packs? If so, they should have the latest language pack (Sep 22), which shouldn't cause the issue.

https://searchfox.org/mozilla-central/source/taskcluster/docker/firefox-snap/runme.sh#55-58

Can someone confirm the version of the language packs installed, either via about:addons->languages or about:support?

Comment 11

[Olivier Tilloy]

Indeed the snap ships its own language packs, which for this build were fetched from https://ftp.mozilla.org/pub/firefox/candidates/92.0.1-candidates/build1/linux-x86_64/xpi/. All 97 of them in the snap have build id 92.0buildid20210901142158.

Starting without a profile, or creating a new profile, evidences that the right language packs are used, because everything is translated as expected. The problem is when upgrading an existing profile from 92.0 to 92.0.1.

Comment 12

[Olivier Tilloy]

Correction: the lang packs shipped in the snap have build id 92.0buildid20210922161155, but those in my profile have build id `92.0buildid20210901142158. This explains the untranslated strings. I am not sure why the profile wasn't upgraded with the new langpacks from the snap, though.

Comment 13

[Olivier Tilloy]

This is very likely a duplicate of bug 1732676.

Comment 15

[Mike Kaply [:mkaply]]

Yep. Version comparator problem here:

https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/internal/XPIInstall.jsm#3910