Closed Bug 1732443 Opened 3 years ago Closed 3 years ago

Remove remaining XRender leftovers

Categories

(Core :: Graphics, task, P3)

Product:
Core
Component:
Graphics
Platform:
Desktop
Linux
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: rmader, Assigned: rmader)

References

Details

Attachments

(1 file)

Bug 1732443 - Remove remaining XRender leftovers,r=aosmond,emilio,stransky
48 bytes, text/x-phabricator-request
Details | Review

bug 1724936 removed Xrender support, but there are still many leftovers and we still link against it. Given that Wayland works well without any Xrender usage, we should be able to remove all these parts without breaking anything.

The few cases where we still use Xlib most likely benefit little
from Xrender. Lets drop the support for it.

Flags: needinfo?(jan)
Pushed by robert.mader@posteo.de:
https://hg.mozilla.org/integration/autoland/rev/c40dba1932cb
Remove remaining XRender leftovers,r=emilio,stransky

Going ahead with this as chances of breakage are quite low. And if something occurs, it's likely easy to fix.

general problem: bug 1733283

Nvidia GTX 1060, 470.63.01 WR EGL SWWR EGL WR GLX SWWR GLX
Gnome X11 ok (not new: non-transparent window corners at the top, bug 1731125/bug 1702546) ok ok (bug 1716049) ok
Gnome X11 with GTK_CSD=1 "ok" (not new: fallback to SW WR: bug 1677314 comment 2) ok ok (bug 1716049) ok
KDE X11 without compositing ok (bug 1723323) ok ok (bug 1723323, bug 1716049) ok
KDE X11 with compositing ok (noticed: vsynctester = 2x 53fps, not the same as bug 1723323 ok ok (bug 1716049 = 2x 30fps) ok

with gpu process:

Nvidia GTX 1060, 470.63.01 WR EGL SWWR EGL WR GLX SWWR GLX
Gnome X11 ok (not new: non-transparent window corners at the top, bug 1731125/bug 1702546) ok ok (bug 1716049) ok
Gnome X11 with GTK_CSD=1 "ok" (fallback to SW WR: bug 1677314 comment 2) ok ok (bug 1716049) ok
KDE X11 without compositing ok (bug 1723323, bug 1730991 comment 6) ok (bug 1730991 comment 6) ok (bug 1723323, bug 1716049, bug 1730991 comment 6) ok (bug 1730991 comment 6)
KDE X11 with compositing ok (noticed: vsynctester=2x 40-60fps, not the same as bug 1723323) ok ok (bug 1716049 = 2x 30 fps) ok (bug 1730991 comment 6 intermittent)

Tested:

  • window corners, pocket extension shadow, main menu shadow
  • tab dragging
  • about:support: WebRender, WebGL, no failures
  • WebGL
  • maximize, unmaximize
  • F11 fullscreen enter, leave
  • two windows

Not tested

  • multiple workspaces, as it seems irrelevant for this patch

mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com
mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref gfx.webrender.software:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com
mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref gfx.x11-egl.force-disabled:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com
mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref gfx.x11-egl.force-disabled:true gfx.webrender.software:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com
GTK_CSD=1 mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com
GTK_CSD=1 mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref gfx.webrender.software:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com
GTK_CSD=1 mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref gfx.x11-egl.force-disabled:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com
GTK_CSD=1 mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref gfx.x11-egl.force-disabled:true gfx.webrender.software:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com

mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref layers.gpu-process.force-enabled:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com -P stdout
mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref layers.gpu-process.force-enabled:true gfx.webrender.software:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com -P stdout
mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref layers.gpu-process.force-enabled:true gfx.x11-egl.force-disabled:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com -P stdout
mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref layers.gpu-process.force-enabled:true gfx.x11-egl.force-disabled:true gfx.webrender.software:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com -P stdout
GTK_CSD=1 mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref layers.gpu-process.force-enabled:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com -P stdout
GTK_CSD=1 mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref layers.gpu-process.force-enabled:true gfx.webrender.software:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com -P stdout
GTK_CSD=1 mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref layers.gpu-process.force-enabled:true gfx.x11-egl.force-disabled:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com -P stdout
GTK_CSD=1 mozregression --repo try --launch 9bdb62d9e81bf68b37352c8c9bfc864d3cb15558 --pref layers.gpu-process.force-enabled:true gfx.x11-egl.force-disabled:true gfx.webrender.software:true -a about:support -a https://webglsamples.org/aquarium/aquarium.html -a https://vsynctester.com -P stdout

Flags: needinfo?(jan)

https://hg.mozilla.org/mozilla-central/rev/c40dba1932cb

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: