1732528 - Stop putting Blobs into nsITransferable when converting from DataTransfer

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Tom S [:evilpie]]

I am not sure if there is something missing about blobImpl = do_QueryInterface(data);, but it doesn't work in my testing when data is a webidl File.

This is important for my case of supporting dragging images on Linux, because we convert the nsIInputStream provided by the platform code to a File in DataTransferItem::FillInExternalData via CreateFileFromInputStream.

Comment 1

[Tom S [:evilpie]]

Attachment: Bug 1732528 - Support webidl Blob/File in nsContentUtils::TransferableToIPCTransferable. r?nika

Depends on D126617

Comment 2

[Tom S [:evilpie]]

I wonder why this isn't required for dragging images across processes to work on Windows.

Comment 3

[Tom S [:evilpie]]

If we never put a Blob into the transferable we don't have to change any of the IPC conversion code.

Comment 4

[Tom S [:evilpie]]

Attachment: Bug 1732528 - Stop putting Blobs into nsITransferable when converting from DataTransfer. r?nika

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia)]

:evilpie: since bug 1731622 is already fixed, presumably this ticket isn't relevant for it? I'm wondering because I'm trying to determine this tickets' severity and priority.

Comment 6

[Tom S [:evilpie]]

(In reply to Mirko Brodesser (:mbrodesser) from comment #5)

:evilpie: since bug 1731622 is already fixed, presumably this ticket isn't relevant for it? I'm wondering because I'm trying to determine this tickets' severity and priority.

No these issues are somewhat unrelated. With bug 1731622 fixed we aren't providing garbage data with the format application/x-moz-nativeimage anymore on any platform. However on Linux (unlike Windows) dragging images from other programs (or Firefox instances) still doesn't work. With this bug fixed we would provide image/png in that case on Linux.

Comment 7

[Anne (:annevk)]

Changing severity to S3 because this affects drag-and-drop of images for end users on Linux per comment 6.

Comment 8

[Tom S [:evilpie]]

Hi Nika! How can I make progress here?

Comment 9

[Tom S [:evilpie]]

Edgar, maybe this is something that you could look at.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9c2ea5329e3
Stop putting Blobs into nsITransferable when converting from DataTransfer. r=nika

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b9c2ea5329e3

Comment 12

[Tom S [:evilpie]]

Release Note Request (optional, but appreciated)
[Why is this notable]: I am obviously biased because this is something I am passionate about, but I think dragging images is not an uncommon operation. A large part of this change actually landed in bug 1437126, but only with this change does dragging images actually become reliable.
[Affects Firefox for Android]: Not really.
[Suggested wording]: Dragging images across Firefox tabs and instances is now more reliably and works with web apps like Google Drive and Photos.
[Links (documentation, blog post, etc)]:

Comment 13

[Pascal Chevrel:pascalc]

Note added to our nightly release notes, we are keeping the relnote flag in bugzilla open so as to have it on our radar for the release, thanks!

Comment 14

[Pascal Chevrel:pascalc]

(In reply to Tom S [:evilpie] from comment #12)

Release Note Request (optional, but appreciated)
[Why is this notable]: I am obviously biased because this is something I am passionate about, but I think dragging images is not an uncommon operation. A large part of this change actually landed in bug 1437126, but only with this change does dragging images actually become reliable.
[Affects Firefox for Android]: Not really.
[Suggested wording]: Dragging images across Firefox tabs and instances is now more reliably and works with web apps like Google Drive and Photos.
[Links (documentation, blog post, etc)]:

I guess that the release note added here is no longer valid for our final notes as we backed out bug 1812611, Tom could you confirm please? Thanks

Comment 15

[Tom S [:evilpie]]

Yes, correct.