1815916 - drag drop double upload

Status: UNCONFIRMED

(Core :: Widget: Gtk, defect, P5)

Description

[zlice]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

• Linux
• Fluxbox
• ROX Filer (gtk2)

Open a private browser.
Drag and drop an image for upload (imgur and other sites)

Actual results:

Get 2 images uploaded

Expected results:

only 1 image

Comment 1

[zlice]

 4:57.52 INFO: Using local file: /tmp/tmpnr2_zg41/fda8e2847c51-shippable--autoland--target.tar.bz2 (downloaded in background)
 4:57.52 INFO: Running autoland build built on 2022-12-16 17:44:07.134000, revision fda8e284
 5:04.00 INFO: Launching /tmp/tmpo2l9tgg4/firefox/firefox
 5:04.00 INFO: Application command: /tmp/tmpo2l9tgg4/firefox/firefox imgur.com -profile /tmp/tmp7u68iua7.mozrunner
 5:04.00 INFO: application_buildid: 20221216171818
 5:04.00 INFO: application_changeset: fda8e2847c515505b7f4fd2b906e768433331127
 5:04.00 INFO: application_name: Firefox
 5:04.00 INFO: application_repository: https://hg.mozilla.org/integration/autoland
 5:04.00 INFO: application_version: 110.0a1
Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): good
 5:14.69 INFO: Narrowed integration regression window from [35fd7fb9, b9c2ea53] (3 builds) to [fda8e284, b9c2ea53] (2 builds) (~1 steps left)
 5:14.69 INFO: No more integration revisions, bisection finished.
 5:14.69 INFO: Last good revision: fda8e2847c515505b7f4fd2b906e768433331127
 5:14.69 INFO: First bad revision: b9c2ea5329e3e99c805f6fdd9e9e8bd6f41d1f0d
 5:14.69 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fda8e2847c515505b7f4fd2b906e768433331127&tochange=b9c2ea5329e3e99c805f6fdd9e9e8bd6f41d1f0d

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Andre Klapper]

Firefox is not mentioned at all in the steps to reproduce. Please provide clear steps to reproduce which leave no room for interpretation.

Comment 4

[zlice]

Open a private browser - in firefox*

?

Comment 5

[Andre Klapper]

Drag and drop an image for upload (imgur and other sites)

Drag and drop an image from where?

Comment 6

[zlice]

Attachment: drag_drop_double_small.mp4

Sorry, I didn't think it was that unclear.

Here is a video. Let me know if you have any other questions.

Comment 7

[zlice]

For clarification - the left is "ROX filer" file-manager, the right is Firefox, the Window Manager is Fluxbox.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

:evilpie, since you are the author of the regressor, bug 1732528, could you take a look?

For more information, please visit auto_nag documentation.

Comment 9

[Tom S [:evilpie]]

Unlike most other file manager that I am aware of, "ROX filer" seems to provide both the file URI via "text/uri-list" and the actual image data via "image/png". Other file managers just provide the file: URI of the dragged file.

I would not necessarily consider this a Firefox bug.

Comment 10

[zlice]

Attachment: dnd_noimg.patch

Thanks, was able to patch ROX so it doesn't dupe. However ROX has been dead for some time now (sourceforge, 2005) so there will not be a patch on that end.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

(In reply to Tom S [:evilpie] from comment #9)

Unlike most other file manager that I am aware of, "ROX filer" seems to provide both the file URI via "text/uri-list" and the actual image data via "image/png". Other file managers just provide the file: URI of the dragged file.

I would not necessarily consider this a Firefox bug.

I wonder why do we do the drag twice then? Is that a a bug on the webpage which fetches both attachments?

Comment 12

[zlice]

It happens on more than imgur. And not in chromium, and obviously not before that commit.

Comment 13

[zlice]

Attachment: dnd_noimg2.patch

Update to that ROX patch. Other one broke the ROX pinboard when dragging items which I don't do very often. Minor testing seems to work :)