1732572 - Can't reopen minimized firefox

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P2)

Description

[aymanamjad314]

Attachment: Demo

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.82 Safari/537.36

Steps to reproduce:

Occurs only on Mac , on all channels of Firefox

Steps to reproduce :
1.Open Firefox , and open any video-calling client ( Google Meet, Zoom , Cisco Webex etc..)
2.Allow camera and microphone permissions
3.Join/start a meeting with camera and mic off/on
4. Minimize Firefox through Cmd. M or by clicking the minimize button

Actual results:

1)Firefox does not open by clicking icon from the dock
2)Microphone icon observed in menu bar , even when mic is switched off

Expected results:

Firefox should open the window when icon is clicked

Comment 1

[aymanamjad314]

(In reply to aymanamjad314 from comment #0)

Created attachment 9242942 [details]
Demo

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.82 Safari/537.36

Steps to reproduce:

Occurs only on Mac , on all channels of Firefox, even after multiple reinstallation

Steps to reproduce :
1.Open Firefox , and open any video-calling client ( Google Meet, Zoom , Cisco Webex etc..)
2.Allow camera and microphone permissions
3.Join/start a meeting with camera and mic off/on
4. Minimize Firefox through Cmd. M or by clicking the minimize button

Actual results:

1)Firefox does not open by clicking icon from the dock
2)Microphone icon observed in menu bar , even when mic is switched off

Expected results:

Firefox should open the window when icon is clicked

Comment 2

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::WebRTC: Audio/Video' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

I can reproduce this locally. I used https://webrtc.github.io/samples/src/content/getusermedia/gum/ and https://webrtc.github.io/samples/src/content/getusermedia/audio/ to access the camera or microphone without needing to start a video call.

I checked using a single monitor (setting my second to mirror the first) an there was no impact.

Comment 4

[aymanamjad314]

(In reply to Nico Grunbaum [:ng, @chew:mozilla.org] from comment #3)

I can reproduce this locally. I used https://webrtc.github.io/samples/src/content/getusermedia/gum/ and https://webrtc.github.io/samples/src/content/getusermedia/audio/ to access the camera or microphone without needing to start a video call.

I checked using a single monitor (setting my second to mirror the first) an there was no impact.

Alright , thanks for the update

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Could you try the following settings in about:config to confirm that this may be an issue with our new sharing indicator?

privacy.webrtc.allowSilencingNotifications = false
privacy.webrtc.legacyGlobalIndicator = true

Comment 6

[aymanamjad314]

(In reply to Nico Grunbaum [:ng, @chew:mozilla.org] from comment #5)

Could you try the following settings in about:config to confirm that this may be an issue with our new sharing indicator?

privacy.webrtc.allowSilencingNotifications = false
privacy.webrtc.legacyGlobalIndicator = true

Sure , I'll do that

Comment 7

[aymanamjad314]

(In reply to Nico Grunbaum [:ng, @chew:mozilla.org] from comment #5)

Could you try the following settings in about:config to confirm that this may be an issue with our new sharing indicator?

privacy.webrtc.allowSilencingNotifications = false
privacy.webrtc.legacyGlobalIndicator = true

I have changed the about:config as requested , and now it seems to be working without a problem , and showing expected behaviour

Comment 8

[aymanamjad314]

I have two questions

1. Will changing these options in about:config affect any other feature in Firefox
   2)What does the sharing indicator look like on Mac , because I do not see anything except a microphone in the menu bar?

Thanks in advance

Comment 9

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:pbz, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[Emma Zühlcke [:emz]]

I can reproduce this on macOS Catalina with Firefox Release 93. Clicking the Firefox dock item does not un-minimize the Firefox window. However, un-minimizing via the other Firefox window item on the right still works.

It looks like clicking the Firefox item focuses the new webrtc sharing indicator. IMO this is generally unexpected. This is extra confusing, because It also seems to try to bring up the invisible indicator for mic / camera sharing.

This is an S3, because workarounds exist. You can use the other window item to un-minimize Firefox or disable the new webrtc indicator by setting rivacy.webrtc.legacyGlobalIndicator = true in about:config.

(Leaving the NI up for priority triage)

(In reply to aymanamjad314 from comment #8)

I have two questions

1. Will changing these options in about:config affect any other feature in Firefox

On macOS this will effectively only disable the new popup which lets you control screen sharing. This is an always-on-top window in addition to the existing screen sharing indicator you get in the top bar.

2)What does the sharing indicator look like on Mac , because I do not see anything except a microphone in the menu bar?

We only show the sharing indicator window for screen sharing. For mic/camera you only get the indicator in the top bar.

Comment 11

[aymanamjad314]

(In reply to Paul Zühlcke [:pbz] from comment #10)

I can reproduce this on macOS Catalina with Firefox Release 93. Clicking the Firefox dock item does not un-minimize the Firefox window. However, un-minimizing via the other Firefox window item on the right still works.

It looks like clicking the Firefox item focuses the new webrtc sharing indicator. IMO this is generally unexpected. This is extra confusing, because It also seems to try to bring up the invisible indicator for mic / camera sharing.

This is an S3, because workarounds exist. You can use the other window item to un-minimize Firefox or disable the new webrtc indicator by setting rivacy.webrtc.legacyGlobalIndicator = true in about:config.

(Leaving the NI up for priority triage)

(In reply to aymanamjad314 from comment #8)

I have two questions

1. Will changing these options in about:config affect any other feature in Firefox

On macOS this will effectively only disable the new popup which lets you control screen sharing. This is an always-on-top window in addition to the existing screen sharing indicator you get in the top bar.

2)What does the sharing indicator look like on Mac , because I do not see anything except a microphone in the menu bar?

We only show the sharing indicator window for screen sharing. For mic/camera you only get the indicator in the top bar.

Understood , thanks for the reply

Comment 12

[Emma Zühlcke [:emz]]

This is most likely a regression from the WebRTC indicator work. The new indicator was rolled out in Bug 1665490 for macOS.
Mike, do you or your team have time to look into this bug?

Comment 13

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1665490

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1732572 - Ignore invisible windows when reopening app from dock, and prioritize top-level browser windows for restoration. r?mstange!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c167592cf86f
Ignore invisible windows when reopening app from dock, and prioritize top-level browser windows for restoration. r=mstange

Comment 16

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c167592cf86f

Comment 17

[Simona Badau, Desktop Test Engineering]

Reproduced on Firefox 94.0.1 on Mac OS X 10.15.
Verified as fixed on the latest Nightly 96.0a1 and on Firefox 95 beta 3 - the minimized window is now reopened when clicking on the Firefox dock item.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR91 approval when you get a chance.

Comment 19

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9246926 [details]
Bug 1732572 - Ignore invisible windows when reopening app from dock, and prioritize top-level browser windows for restoration. r?mstange!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Bug fix for a case where it would seem like Firefox cannot have its window restored by clicking on the Dock icon on macOS when using mic/camera sharing.
• User impact if declined: macOS users visiting sites that use the WebRTC APIs to capture mic/camera inputs might find that they cannot restore their browser window easily after minimizing it to the dock.
• Fix Landed on Version: 95
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a very simple patch in a pretty isolated part of the codebase (the routine that handles restoring windows from the macOS dock).
• String or UUID changes made by this patch: None.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9246926 [details]
Bug 1732572 - Ignore invisible windows when reopening app from dock, and prioritize top-level browser windows for restoration. r?mstange!

Approved for 91.4esr.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/ec4389b44990

Comment 22

[Simona Badau, Desktop Test Engineering]

Verified as fixed on Firefox 91.4.0 esr on Mac OS X 10.15 and macOS Big Sur 11.6 - the minimized Firefox window can now be reopened. However, I noticed a flicker when reopening the minimized window by clicking on the Firefox dock icon, I logged Bug 1743391 to cover that issue.