1732585 - Provide a way to search related (phabricator revision) review/bugzilla comments related to the current file

Status: NEW

(Webtools :: Searchfox, enhancement)

Description

[Andrew Sutherland [:asuth] (he/him)]

Use Case

Often when I'm doing a code review I find myself:

1. Using searchfox to look at the current code.
2. Feeling like I've previously commented on some aspect of what I'm currently reviewing and wanting to consult my previous comments and then having to do a lot of manual digging.

Existing Manual Procedure

Usually I end up using some combination of:

1. Thunderbird global search
2. Firefox Awesomebar (megabar?) with ctrl-f
3. Opening prior bugs from the blame sidebar or revision control and then manually also opening the related reviews with ctrl-f

One complication is that until bug 1666365 is fixed, I no longer get emails that contain the contents of what I've written in reviews, which means that Thunderbird global search doesn't actually work unless someone has quoted my responses.

Blue Sky Hand-Waving Proposal

Given that both Bugzilla and Phabricator have quite reasonable APIs, it could make sense to provide some way to perform a ctrl-f equivalent search across the bugs and phabrication revisions that have recently landed against the current file (including ones that have been backed out and maybe even just WIP phabricator revisions that haven't landed yet but which the API does make available for us to find).

This need not be a direct feature of searchfox, but instead could be something where searchfox provides something like:

• A navigation box-exposed mini UI to enter a search query that opens search links to bugzilla and phabricator that are appropriately constrained to some combination of:
  • Bugs mentioned in (recent) commits to the file.
  • Contemporaneous bug (comments) from the same component as the current file or from the components that bugs that touched this file were filed against. Or that were related through the bug dependency/see-also graph, etc.
  • Phabricator revisions mentioned in (recent) commits to the file.
  • Phabricator revisions that touch the current file.
• UI exposure to initiate a search of the https://github.com/asutherland/glodastrophe messaging client's synchronized data from its bugzilla client and phabricator client integration with searchfox providing some filtering constraints.
• Something else!

This is really pie-in-the-sky thinking right now, but I am interested in the possibility that there might be a low-hanging 80% solution.