1732759 - Unprefix fit-content keyword.

Status: RESOLVED FIXED

(Core :: Layout, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1732759 - Unprefix -moz-fit-content. r=#layout-reviewers

I'm not aware of any reason we shouldn't do this, as it is interoperable
with other browsers, and it causes compat issues from sites that forget
to use the prefixed version.

Try is running, probably a bunch of other new tests are passing.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1732759 - Test updates. r=#layout-reviewers

Mostly progressions, as expected, but there are two bits that deserve
some attention:

• First there are two table tests that regress (because we were
  treating fit-content like auto). However Chromium fails the
  non-tentative one also, just in a different way, so I think it's
  worth punting on changing table layout and go to the CSSWG to figure
  out if "auto" is the desired behavior here.

• Second, there's another test that regresses
  (position-absolute-replaced-minmax.html) for the same reason, we used
  to treat the size as "auto".

  The test that regresses comes from a Chromium crash
  (https://bugs.chromium.org/p/chromium/issues/detail?id=1010798) and
  the relevant behavior different also affects other intrinsic
  keywords, so I don't think we should address it here, and is unlikely
  to be a common case in the wild if we hadn't hit this before with
  other unprefixed keywords IMO.

  In any case I filed
  https://bugzilla.mozilla.org/show_bug.cgi?id=1732780 for this
  behavior difference to investigate later.

• Third, I removed fit-content from min-{width,height}-invalid. They
  are valid sizing keywords in css-sizing-5, and they apply to these
  properties. Other browsers also parse it.

Depends on D126718

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7905b23762e5
Unprefix -moz-fit-content. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/4d3c7ac994c7
Test updates. r=dholbert

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7905b23762e5
https://hg.mozilla.org/mozilla-central/rev/4d3c7ac994c7

Comment 5

[dgrogan (chrome)]

\o/
:)

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31012 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot