1495868 - Unprefix -moz-available keyword

Status: NEW

(Core :: Layout, task, P3)

Description

[Boris Chiou [:boris]]

We'd like to unprefix -moz-max-content and -moz-min-content in Bug 1322780. For -moz-fit-content and -moz-available, we should also unprefix them after the css sizing level 4 addresses them. This bug should also include renaming "-moz-available" to "stretch" [1].

[1] https://drafts.csswg.org/css-sizing/#sizing-values

Comment 1

[Boris Chiou [:boris]]

From Bug 1322780 Comment 3 

There are two test files for image fill:
1. attachment 8820716 [details]
2. attachment 8820886 [details]

It seems Gecko only support -moz-available in the inline-direction though.
We should probably not unprefix -moz-available before we support it in both.

Comment 2

[Thomas Wisniewski [:twisniewski]]

The lack of unprefixed fit-content is causing cosmetic layout issues on dns.google.com (which only specifies the unprefixed variant).

Comment 3

[Firefox Bug Husbandry Bot]

Migrating Webcompat whiteboard priorities to project flags. See bug 1547409.

Comment 4

[Firefox Bug Husbandry Bot]

See bug 1547409. Migrating whiteboard priority tags to program flags.

Comment 6

[Karl Dubost💡 :karlcow]

Instead of unprefixing -moz-available, It would be probably better to have an alias for -webkit-fill-available.
And even before that it would be better to check if there is any attempt at using available as a term.

Comment 7

[Karl Dubost💡 :karlcow]

Philip,

I don't see any counters on Chromium for -webkit-fill-available
https://www.chromestatus.com/features#fill-available

And no specific issue about its future, apart issues such as
https://bugs.chromium.org/p/chromium/issues/detail?id=807708
I didn't find a bug for implementing stretch keyword too.

Comment 10

[Philip Jägenstedt [:foolip]]

I can confirm there's no use counter for this in Chrome, since it's a property value, and we only generate use counters automatically for properties.

Comment 11

[Daniel Holbert [:dholbert]]

I noticed this bug in a list of "WebCompat Priority: P2" bugs -- adding some notes:

(In reply to Boris Chiou [:boris] from comment #0)
[...]

For -moz-fit-content [...] we should also unprefix
(In reply to Thomas Wisniewski [:twisniewski] from comment #2)
The lack of unprefixed fit-content is causing cosmetic layout issues on dns.google.com (which only specifies the unprefixed variant).

Note, we fixed this specific part (unprefixing fit-content) in bug 1732759.

These associated webcompat issues were all cases where a website depended on that specific unprefixed keyword:
https://webcompat.com/issues/22494
https://github.com/webcompat/web-bugs/issues/59967
https://github.com/webcompat/web-bugs/issues/73095

The other two associated webcompat issues seem to have been associated with this bug due to a site depending on -webkit-fill-available:
https://webcompat.com/issues/56698
https://github.com/webcompat/web-bugs/issues/92483

...which we should perhaps consider supporting as an alias (per comment 6) independently of the bundle of unprefixing work that this bug proposes to eventually do (in comment 0 here). The bug to alias -webkit-fill-available should perhaps have some associated WebCompat Priority assigned to it, but I'm not sure there's any particular webcompat priority for the other unprefixing work here (outside of fit-content which we've already unprefixed).

Comment 12

[Daniel Holbert [:dholbert]]

[And I guess we already have bug 1872755 on file to support -webkit-fill-available. --> Adding that as a dependency, and transferring the WebCompat Priority status to that bug.]
[And while I'm editing things, I'll remove " -moz-fit-content" from the bug title here, since we're already done with that unprefixing as noted above.]

Comment 13

[Daniel Holbert [:dholbert]]

[moving two see-also webcompat bug associations to bug 1872755, too]

Comment 14

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #11)

The bug to alias -webkit-fill-available should perhaps have some associated WebCompat Priority assigned to it, but I'm not sure there's any particular webcompat priority for the other unprefixing work here (outside of fit-content which we've already unprefixed).

--> resetting WebCompat Priority for this bug here, after moving the former value over to bug 1872755