1732797 - Rename "System theme" to "System theme — auto"

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P2)

Description

[Harry Twyford]

Content Strategy has asked we rename the system theme to better suit the new theme-picking UI being added in about:welcome.

Comment 1

[Harry Twyford]

Attachment: Bug 1732797 - Rename "System theme" to "System theme — auto". r?#extension-reviewers!

Comment 2

[Shane Caraveo (:mixedpuppy)]

It would be nice if bugs like this also captured a reason.

Comment 3

[Harry Twyford]

about:welcome is going to show themes grouped by color. In each set of colors, it'll have a variant picker. For the new colorful themes, it'll show the three colors in a group together (for example, all the Graffiti themes) and other picker for Bold, Balanced, or Soft. For the default themes, the color will be called "Default" and the picker will also Light, Dark, and Auto. Content Strategy wants to add the word "Auto" to the system theme so that people who select Default > Auto in about:welcome can make the connection that "System theme – Auto" is the same theme. There's a spec here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/538c138a40dd
Rename "System theme" to "System theme — auto". r=fluent-reviewers,mixedpuppy,flod

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_ext_management_themes.js

• backout: https://hg.mozilla.org/integration/autoland/rev/45cb924ad91fe330dadd11046cac31a0f7ace4d0

• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=538c138a40dd71c0cab0d41b9f459888fc3cf39e&group_state=expanded&selectedTaskRun=e54IOt3lTfWmcmVHzUw2Qg.0

• failure log: https://treeherder.mozilla.org/logviewer?job_id=353267856&repo=autoland&lineNumber=7042

[task 2021-09-30T18:27:48.647Z] 18:27:48     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_management_themes.js | webextension theme installed - 
[task 2021-09-30T18:27:48.647Z] 18:27:48     INFO - System theme — auto was disabled
[task 2021-09-30T18:27:48.647Z] 18:27:48     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_management_themes.js | addon is theme - Expected: theme, Actual: theme - 
[task 2021-09-30T18:27:48.647Z] 18:27:48     INFO - Buffered messages finished
[task 2021-09-30T18:27:48.650Z] 18:27:48     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_management_themes.js | default disabled - Got "System theme — auto", expected "System theme"
[task 2021-09-30T18:27:48.650Z] 18:27:48     INFO - Stack trace:
[task 2021-09-30T18:27:48.650Z] 18:27:48     INFO - chrome://mochikit/content/browser-test.js:test_is:1364
[task 2021-09-30T18:27:48.650Z] 18:27:48     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_management_themes.js:test_management_themes:140
[task 2021-09-30T18:27:48.657Z] 18:27:48     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_management_themes.js | The extension with id [e-mail] was returned by getAll. - 

Comment 6

[Natalia Csoregi [:nataliaCs]]

Also failing:

• TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js | It's always version 1.2 - Got "1.3", expected "1.2"

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5a59b2d7577
Rename "System theme" to "System theme — auto". r=fluent-reviewers,mixedpuppy,flod

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d5a59b2d7577

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Natalia Csoregi [:nataliaCs] from comment #5)

Backed out for failures on browser_ext_management_themes.js

• backout: https://hg.mozilla.org/integration/autoland/rev/45cb924ad91fe330dadd11046cac31a0f7ace4d0

== Change summary for alert #31719 (as of Wed, 06 Oct 2021 08:26:22 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
45%	wikipedia fcp	windows10-64-shippable-qr	warm webrender	648.71 -> 359.75
19%	amazon fcp	windows10-64-shippable-qr	fission warm webrender	215.04 -> 173.83
7%	ebay fcp	windows10-64-shippable-qr	warm webrender	174.60 -> 161.67

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=31719