1729738 - Migrate usages of extension.(.*)@mozilla.org.* from properties to Fluent

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P3)

Description

[Erik Nordin [:nordzilla]]

As part of the M2 milestone for arewefluentyet, there are many usages of properties that should be moved to Fluent.

There are many that are of the following form:

[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]

Many of these are generated [here] as an attempt hopefully match on a string and localize something, though many of these strings do not exist.

We should look at the actual sources of the LOCALE_BUNDLES for this file [here]:

• global-extension-fields.properties
• app-extension-fields.properties

And move those properties to fluent to use them explicitly.

Comment 1

[Release mgmt bot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Form Autofill' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

And move those properties to fluent to use them explicitly.

In particular, we should not request localization of IDs we don't have, because it triggers deep fallback in Fluent.

So the code should look like this:

const LOCALIZED_EXTENSION_NAMES = [
  "default-theme",
  "firefox-compact-light",
  "firefox-compact-dark",
  "firefox-alpenglow",
];

function chooseValue(aAddon, aObj, aProp) {
  let repositoryAddon = aAddon._repositoryAddon;
  let objValue = aObj[aProp];

  // ...

  if (!aAddon.id in LOCALIZED_EXTENSION_NAMES) {
    return [objValue, false];
  }

  let l10nId = `extension-meta-${aAddon.id}`;
  let msg = l10n.formatMessagesSync([{id: l10nId}]); // XXX: can we do async here?
  
  if (aProp == "title") {
    return [msg.title, false];
  } else if (aProp == "description") {
    return [msg.description, false];
  } else {
    throw new Exception("This should never happen");
  }
}

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

And l10n is probably a custom const l10n = new Localization(); here if I'm not mistaken.

Comment 4

[kpatenio]

Attachment: Bug 1729738 - Migrate extension.(.*)@mozilla.org.* from properties to Fluent. r=mtigley!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a72ff9328e5
Migrate extension.(.*)@mozilla.org.* from properties to Fluent. r=mtigley,fluent-reviewers,robwu,flod

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/4a72ff9328e5

Comment 7

[[:fabrice] Fabrice Desré]

This change introduced a dependency of toolkit/mozapps/extensions/internal/XPIDatabase.jsm on browser/locales/en-US/browser/appExtensionFields.ftl which causes issues on non-Firefox products.

I'm not sure what the best way to deal with that is, but the extension-default-theme-* strings should move back under toolkit.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

:fabrice - :robwu is looking for a better solution in bug 1733466.

Comment 9

[[:fabrice] Fabrice Desré]

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #8)

:fabrice - :robwu is looking for a better solution in bug 1733466.

thanks!