1732811 - AccessibleCaret does not update size if it is position inside an (in process) iframe on desktop with pinch zoom

Status: NEW

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

Set layout.accessiblecaret.enabled=true
layout.accessiblecaret.hide_carets_for_mouse_input=false

Find a page with an in process iframe that has some text to select (https://hsivonen.fi/fission-host.html works for this if you have fission disabled). Select some text in the iframe, pinch zoom in. The AccessibleCaret grows in size. If you do the same thing outside of the iframe it does not grow.

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

tnikkel: is this reproducible in Responsive Design Mode?
I didn't manage to pinch zoom there on Ubuntu 20.04 with a touchpad (not touchscreen).
Also, on which OS did this occur?

Comment 2

[Timothy Nikkel (:tnikkel)]

I'm testing on macOS, although I think the same behaviour will happen on any OS, might even happen on android?

I don't know how to get the accessible caret to show up in RDM, I can't figure out how to select any text (I'm not super familiar with RDM).

Provided you have capable hardware (touchpad) I think you have to jump through a few hoops to get pinch zoom on a touchpad to work on Linux (run in wayland mode maybe?). However, if you change the pref mousewheel.with_control.action to 5 then you can use the mouse wheel while holding control to perform pinch zoom (there are some differences from real pinch zoom, but it should be good enough to test).

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

(In reply to Timothy Nikkel (:tnikkel) from comment #2)

I'm testing on macOS, although I think the same behaviour will happen on any OS, might even happen on android?

I don't know how to get the accessible caret to show up in RDM, I can't figure out how to select any text (I'm not super familiar with RDM).

Provided you have capable hardware (touchpad) I think you have to jump through a few hoops to get pinch zoom on a touchpad to work on Linux (run in wayland mode maybe?). However, if you change the pref mousewheel.with_control.action to 5 then you can use the mouse wheel while holding control to perform pinch zoom

Thanks, that allows to reproduce the issue in RDM on Ubuntu 20.04.

(there are some differences from real pinch zoom, but it should be good enough to test).

Comment 4

[Petru-Mugurel Lingurar [:petru]]

This seems to be reproducing also on mobile, albeit intermittently.
Saw in the latest Fenix Nightly - https://drive.google.com/file/d/1XVnz4hntvMEG9bU49OjxyJN7uuP3c4v4/view?usp=sharing

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

(In reply to Petru-Mugurel Lingurar [:petru] from comment #4)

This seems to be reproducing also on mobile, albeit intermittently.
Saw in the latest Fenix Nightly - https://drive.google.com/file/d/1XVnz4hntvMEG9bU49OjxyJN7uuP3c4v4/view?usp=sharing

Thanks.

It seems the bug isn't in Selection code, but somewhere in panning and zooming code. However, given the description of "Core::Panning and Zooming", it should likely belong to "Core::Layout".

Comment 6

[Timothy Nikkel (:tnikkel)]

Oh yeah, the bug is likely in layout/base/AccessibleCaret.cpp or related

But I filed this bug in this component because of this line

https://searchfox.org/mozilla-central/rev/d10188f9b4f1c4974264f3925505a0498d346c57/layout/base/moz.build#19

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:boris, could you have a look please?

For more information, please visit auto_nag documentation.