Closed Bug 1732919 Opened 1 year ago Closed 1 year ago

Use user activation for the Storage Access API

Categories

(Core :: Privacy: Anti-Tracking, task, P2)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: johannh, Assigned: pbz)

References

(Blocks 2 open bugs)

Details

Attachments

(4 files)

Instead of the deprecated user gesture/interaction mechanism.

We need this for the Kinja shim. When the user accepts the requestStorageAccess prompt we need to renew the user activation.

Assignee: nobody → pbz
Blocks: 1656171
Status: NEW → ASSIGNED
Blocks: 1494123
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c86a1d595b8
Use user activation for Storage Access API. r=edgar,anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/759d9b550cca
Update tests for new Storage Access API user activation behavior. r=anti-tracking-reviewers,timhuang

Backed out for causing mochitest and wpt failures on browser_webconsole_requestStorageAccess_errors.js

Flags: needinfo?(pbz)

The base patch updated the behavior of document.requestStorageAccess to require user activation and moved the user activation check to the top of the method.
To test for the other rsA error messages, which are in the user activation guarded parts of the method, we need to simulate user activation.
Requiring user activation also means we should not run the rsA requests in parallel to avoid side effects.

Depends on D127152

Flags: needinfo?(pbz)
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/096f7a2f65fe
Use user activation for Storage Access API. r=edgar,anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/887e3b523bf3
Update tests for new Storage Access API user activation behavior. r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/00afa32396d0
Update browser_webconsole_requestStorageAccess_errors for updated user activation requirement. r=nchevobbe
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93edca563ab6
Use user activation for Storage Access API. r=edgar,anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/bf5c1bc311c8
Update tests for new Storage Access API user activation behavior. r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/80776c2142e0
Update browser_webconsole_requestStorageAccess_errors for updated user activation requirement. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/37b33717e0b6
Update requestStorageAccess.sub.window.js test expectations. r=anti-tracking-reviewers,timhuang
Flags: needinfo?(pbz)
See Also: → 1557097
You need to log in before you can comment on or make changes to this bug.