1732919 - Use user activation for the Storage Access API

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P2)

Description

[Johann Hofmann [:johannh]]

Instead of the deprecated user gesture/interaction mechanism.

Comment 1

[Paul Zühlcke [:pbz]]

We need this for the Kinja shim. When the user accepts the requestStorageAccess prompt we need to renew the user activation.

Comment 2

[Paul Zühlcke [:pbz]]

Attachment: Bug 1732919 - Use user activation for Storage Access API. r=edgar!,#anti-tracking-reviewers!

Comment 3

[Paul Zühlcke [:pbz]]

Attachment: Bug 1732919 - Update tests for new Storage Access API user activation behavior. r=#anti-tracking-reviewers!

Depends on D127151

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c86a1d595b8
Use user activation for Storage Access API. r=edgar,anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/759d9b550cca
Update tests for new Storage Access API user activation behavior. r=anti-tracking-reviewers,timhuang

Comment 5

[Cristian Tuns]

Backed out for causing mochitest and wpt failures on browser_webconsole_requestStorageAccess_errors.js

• Backout link
• Push with failures
• mochitest Failure Log
• wpt failure log

Comment 6

[Paul Zühlcke [:pbz]]

Attachment: Bug 1732919 - Update browser_webconsole_requestStorageAccess_errors for updated user activation requirement. r=nchevobbe!,johannh

The base patch updated the behavior of document.requestStorageAccess to require user activation and moved the user activation check to the top of the method.
To test for the other rsA error messages, which are in the user activation guarded parts of the method, we need to simulate user activation.
Requiring user activation also means we should not run the rsA requests in parallel to avoid side effects.

Depends on D127152

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/096f7a2f65fe
Use user activation for Storage Access API. r=edgar,anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/887e3b523bf3
Update tests for new Storage Access API user activation behavior. r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/00afa32396d0
Update browser_webconsole_requestStorageAccess_errors for updated user activation requirement. r=nchevobbe

Comment 8

[Andreea Pavel [:apavel]]

Backed out for wpt failures at requestStorageAccess.sub.window.html

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=bftXkNaeT4yepjgUeFLuQg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=00afa32396d0d8163171092e884f8563df0f6ab5

Failure log: https://treeherder.mozilla.org/logviewer?job_id=354517969&repo=autoland&lineNumber=10231

Backout: https://hg.mozilla.org/integration/autoland/rev/b318026aa323e9a4208c54ad2dbadd94779c3c66

Comment 9

[Paul Zühlcke [:pbz]]

Attachment: Bug 1732919 - Update requestStorageAccess.sub.window.js test expectations. r=#anti-tracking

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93edca563ab6
Use user activation for Storage Access API. r=edgar,anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/bf5c1bc311c8
Update tests for new Storage Access API user activation behavior. r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/80776c2142e0
Update browser_webconsole_requestStorageAccess_errors for updated user activation requirement. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/37b33717e0b6
Update requestStorageAccess.sub.window.js test expectations. r=anti-tracking-reviewers,timhuang

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/93edca563ab6
https://hg.mozilla.org/mozilla-central/rev/bf5c1bc311c8
https://hg.mozilla.org/mozilla-central/rev/80776c2142e0
https://hg.mozilla.org/mozilla-central/rev/37b33717e0b6