1732948 - Request a "mach create-mach-environment" if Mach venv out-of-date

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Mitchell Hentges [:mhentges] 🦀]

Note: currently, mach_venv.up_to_date() takes ~500ms to run, which is a lot for every Mach invocation. Let's land this after performance there improves (probably by removing the pip list call, using hashes instead, etc).

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1732948: Assert that the Mach venv isn't out-of-date during init

As we leverage the Mach environment more, it becomes increasingly
important that it isn't out-of-date on developer machines.

Add an up_to_date() check during Mach initialization.
To minimize the cost to startup, I'm skipping the "pip list" check.

This change required moving virtualenv from mozbuild to mach to
make it available during the early stage of Mach init.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mhentges, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Probably landing this today, it was a dependent on the stack :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e68fffdead19
Assert that the Mach venv isn't out-of-date during init r=ahal

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e68fffdead19