1738947 - Spurious reconfigures due to missing virtualenv.py

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

$ REBUILD_CHECK=1 mach build faster                                                                                                                                                                                                       
 0:00.67 Clobber not needed.
 Input not found: /home/emilio/src/moz/gecko-5/python/mozbuild/mozbuild/virtualenv.py
 0:00.67 /home/emilio/.mozbuild/_virtualenvs/mach/bin/python /home/emilio/src/moz/gecko-5/configure.py
 0:00.86 Re-executing in the virtualenv
 0:01.05 Adding configure options from /home/emilio/src/moz/gecko-5/.mozconfig
 0:01.05   --enable-artifact-builds
 0:01.05   --enable-debug
 0:01.05   MOZBUILD=/home/emilio/.mozbuild
 0:01.05   MOZCONFIGS=/home/emilio/dotfiles/common/.mozconfigs/mozconfigs
 0:01.05   ARTIFACT_BUILD=1
 0:01.05 checking for vcs source checkout... git
....

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1738947 - Fix path to virtualenv.py. r=mhentges

It was moved in bug 1732948.

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Patch incoming. You beat me to it 😁
Side-note: I'd recommend doing ./mach ... instead of mach ... so that Mach doesn't use Python sources from one tree, but related non-Python files from the other. This is mostly an issue when handling multiple trees.

(We used to recommend adding Mach to the $PATH before Python shenanigans were better-understand, is what I'm piecing together here in 2021).

Comment 3

[Emilio Cobos Álvarez [:emilio]]

(In reply to Mitchell Hentges [:mhentges] 🦀 from comment #2)

Patch incoming.
Side-note: I'd recommend doing ./mach ... instead of mach ... so that Mach doesn't use Python sources from one tree, but related non-Python files from the other. This is mostly an issue when handling multiple trees.

(We used to recommend adding Mach to the $PATH before Python shenanigans were better-understand, is what I'm piecing together here in 2021).

FWIW I don't have mach in $PATH, instead I have:

mach() {
  local tree=$(git rev-parse --show-toplevel 2>/dev/null || hg root 2>/dev/null)
  if [ -f "$tree/mach" ]; then
    "$tree/mach" "$@"
  else
    echo "Not in a mozilla tree"
  fi
}

In my shell config, which does the right thing :-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9b4ccef00db
Fix path to virtualenv.py. r=mhentges

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/1ef6c9bb62b9
Fix path to virtualenv.py. r=mhentges a=graft

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1ef6c9bb62b9

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f9b4ccef00db

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1732948