1733008 - 5700u apu with vega8 (0x164c) doesnt have webrender enabled by default

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[emailsaddres]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

I have lenovo laptop with a 5700u apu.
when I create a firefox profile I and open about:support I get "Compositing WebRender(software)"
which seems to mean that I dont have webrender in gpu.
is this gpu/apu supported?

the gpu info that page is :
GPU #1
Active Yes
Description AMD RENOIR (DRM 3.40.0, 5.10.69-1-lts, LLVM 12.0.1)
Vendor ID 0x1002
Device ID 0x164c
Driver Vendor mesa/radeonsi
Driver Version 21.2.2.0
RAM 0

Actual results:

no webrender

Expected results:

should support webrender

Comment 1

[emailsaddres]

after searching I found this issue too https://bugzilla.mozilla.org/show_bug.cgi?id=1633411
but it said fixed in firefox 77.
am I missing something?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Darkspirit]

https://searchfox.org/mozilla-central/rev/8db61933e64b13c4a0ae456bcaccbd86a519ccc5/widget/GfxDriverInfo.cpp#741
https://github.com/jrmuizel/gpu-db/commit/347fa645415e72b617e5823ce7489a41313efbda

Comment 4

[emailsaddres]

I dont understand the purpose of the added links but if it is for others to use and add them for firefox please say so.
also mostakenly linked to a bug about raven-ridge but this gpu is GPU: AMD ATI 04:00.0 Lucienne show in neofetch comman.
and in lshw it is shown as "product: Lucienne [1002:164C]"

Comment 5

[:gerard-majax]

Same here with a brand new ThinkPad P14s AMD Gen2, with Ryzen 7 Pro 5850U CPU:

$ LC_ALL=C sudo lshw -C video -numeric
  *-display
       description: VGA compatible controller
       product: Cezanne [1002:1638]
       vendor: Advanced Micro Devices, Inc. [AMD/ATI] [1002]
       physical id: 0
       bus info: pci@0000:08:00.0
       logical name: /dev/fb0
       version: d1
       width: 64 bits
       clock: 33MHz
       capabilities: pm pciexpress msi msix vga_controller bus_master cap_list fb
       configuration: depth=32 driver=amdgpu latency=0 mode=3840x2160 visual=truecolor xres=3840 yres=2160
       resources: iomemory:80-7f iomemory:80-7f irq:76 memory:860000000-86fffffff memory:870000000-8701fffff ioport:1000(size=256) memory:fd300000-fd37ffff

Comment 6

[:gerard-majax]

For what it's worth, adding 0x1638 where you mentionned in comment #3 seems not to crash and I have a debug build kinda working

Comment 7

[:gerard-majax]

Attachment: about:support with added 0x1638 device

Comment 8

[Darkspirit]

Nothing wild. Those two PCI ids were pushed to GitHub, but it was forgotten to add them to the WebRender whitelist.

Comment 9

[:gerard-majax]

(In reply to Darkspirit from comment #8)

Nothing wild. Those two PCI ids were pushed to GitHub, but it was forgotten to add them to the WebRender whitelist.

Ok, I've pushed a patch for my specific device in bug 1733412

Comment 10

[Darkspirit]

(In reply to emailsaddres from comment #0)
Workaround: Open about:config, set gfx.webrender.all to true and restart Firefox to force-enable WebRender.

Comment 11

[emailsaddres]

(In reply to Darkspirit from comment #10)

(In reply to emailsaddres from comment #0)
Workaround: Open about:config, set gfx.webrender.all to true and restart Firefox to force-enable WebRender.

I have dont that and after firefox NOT burning down I created this bug so that others can benefit.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Andrew, can we remove the allow listing on Linux?

Comment 13

[Pablo]

Unable to reproduce on release with Ubuntu 20 since it requires specific hardware.

Comment 14

[Robert Mader [:rmader]]

Attachment: Bug 1733008 - Allow AMD Lucienne devices (0x164c) r=#gfx-reviewers

Comment 15

[Robert Mader [:rmader]]

Sorry this took so long. We should really close bug 1736267.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ed87284de01
Allow AMD Lucienne devices (0x164c) r=gfx-reviewers,jrmuizel

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0ed87284de01