1733009 - Get rid of LineBreaker::Prev()

Status: RESOLVED FIXED

(Core :: Internationalization, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Filed per Makoto's bug 1722484 comment 2.

Prev() is used by serializer (xml and text) and quote wrap. But I guess that we can avoid Prev() by rewriting serializer, Or we provide simple text character width wrap API.

So we should remove LineBreaker::Prev(), and rewrite the callers. If possible, provider a general API for text wrapping.

Comment 1

[Jonathan Kew [:jfkthame]]

To minimize the disruption to callers, one possible approach here would be not to remove Prev() but instead to reimplement it in a form that doesn't depend on the underlying break-finding engine to support backward iteration.

A fairly simple strategy would be to do a naïve backwards scan for whitespace, and then use Next() to look forwards for any potential break within the range just scanned. In principle this would be slightly less performant than a backwards-iterator that directly finds breaks, but for our (very limited) use cases I don't think it would matter.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1733009 - Remove LineBreaker::Prev().

Depends on D128558

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d2f9569baee
Remove LineBreaker::Prev(). r=jfkthame,m_kato

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/3d2f9569baee