Get rid of LineBreaker::Prev() in nsPlainTextSerializer
Categories
(Core :: DOM: Serializers, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(5 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
Bug 1733876 Part 5 - Simply line wrapping logic involving line breaker in FindWrapIndexForContent().
48 bytes,
text/x-phabricator-request
|
Details | Review |
This fixed part of Bug 1733009.
|
Assignee | |
Comment 1•2 years ago
|
||
Depends on D127379
|
|
Assignee | |
Comment 2•2 years ago
|
||
With this edge case explicitly considered, it will be easier for the
following patches to simplify logic in FindWrapIndexForContent().
Depends on D127381
|
|
Assignee | |
Comment 3•2 years ago
|
||
This patch only moves logic, and shouldn't change the behavior.
Depends on D127382
|
|
Assignee | |
Comment 4•2 years ago
|
||
This is required by the next part.
Depends on D127383
|
|
Assignee | |
Comment 5•2 years ago
|
||
The purpose of this patch is to remove LineBreaker::Prev(), and audit
the deprecated LineBreaker::DeprecatedNext() (added in bug 1733872).
Add blockquotecite gtest to make sure short line wrapping with
blockquote citation still works. The testcase's behavior is not changed.
Depends on D127384
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/dd5f9ce8a831 Part 1 - Remove unused kNoFlags in nsPlainTextSerializer.cpp. r=mbrodesser https://hg.mozilla.org/integration/autoland/rev/2a6422635d37 Part 2 - Run line wrapping algorithm only if content of current line is not empty. r=m_kato,mbrodesser https://hg.mozilla.org/integration/autoland/rev/b06880832da2 Part 3 - Consolidate logic dealing with and without aLineBreaker in FindWrapIndexForContent(). r=m_kato https://hg.mozilla.org/integration/autoland/rev/6f0a6fcd5f5e Part 4 - Allow GetUnicharStringWidth() to support mozilla::Span substring argument. r=m_kato https://hg.mozilla.org/integration/autoland/rev/f7f60a86bf47 Part 5 - Simply line wrapping logic involving line breaker in FindWrapIndexForContent(). r=m_kato
Backout by nerli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb78120056f6 Backed out 5 changesets for causing build windows bustages CLOSED TREE
|
||
Comment 8•2 years ago
|
||
Backed out 5 changesets (Bug 1733876) for causing build windows bustages CLOSED TREE
Log: https://treeherder.mozilla.org/logviewer?job_id=354025941&repo=autoland&lineNumber=17330
Backout: https://hg.mozilla.org/integration/autoland/rev/eb78120056f67fa51e8153039909d98f5d160087
|
|
Assignee | |
Updated•2 years ago
|
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5c7ea057db25 Part 1 - Remove unused kNoFlags in nsPlainTextSerializer.cpp. r=mbrodesser https://hg.mozilla.org/integration/autoland/rev/dd3ea0d8556f Part 2 - Run line wrapping algorithm only if content of current line is not empty. r=m_kato,mbrodesser https://hg.mozilla.org/integration/autoland/rev/9fc206a0b925 Part 3 - Consolidate logic dealing with and without aLineBreaker in FindWrapIndexForContent(). r=m_kato https://hg.mozilla.org/integration/autoland/rev/d8baa8f2e4c6 Part 4 - Allow GetUnicharStringWidth() to support mozilla::Span substring argument. r=m_kato https://hg.mozilla.org/integration/autoland/rev/7f1e13c8839d Part 5 - Simply line wrapping logic involving line breaker in FindWrapIndexForContent(). r=m_kato
|
||
Comment 10•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5c7ea057db25
https://hg.mozilla.org/mozilla-central/rev/dd3ea0d8556f
https://hg.mozilla.org/mozilla-central/rev/9fc206a0b925
https://hg.mozilla.org/mozilla-central/rev/d8baa8f2e4c6
https://hg.mozilla.org/mozilla-central/rev/7f1e13c8839d
Description
•