1733876 - Get rid of LineBreaker::Prev() in nsPlainTextSerializer

Status: RESOLVED FIXED

(Core :: DOM: Serializers, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

This fixed part of Bug 1733009.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1733876 Part 1 - Remove unused kNoFlags in nsPlainTextSerializer.cpp.

Depends on D127379

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1733876 Part 2 - Run line wrapping algorithm only if content of current line is not empty.

With this edge case explicitly considered, it will be easier for the
following patches to simplify logic in FindWrapIndexForContent().

Depends on D127381

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1733876 Part 3 - Consolidate logic dealing with and without aLineBreaker in FindWrapIndexForContent().

This patch only moves logic, and shouldn't change the behavior.

Depends on D127382

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1733876 Part 4 - Allow GetUnicharStringWidth() to support mozilla::Span substring argument.

This is required by the next part.

Depends on D127383

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1733876 Part 5 - Simply line wrapping logic involving line breaker in FindWrapIndexForContent().

The purpose of this patch is to remove LineBreaker::Prev(), and audit
the deprecated LineBreaker::DeprecatedNext() (added in bug 1733872).

Add blockquotecite gtest to make sure short line wrapping with
blockquote citation still works. The testcase's behavior is not changed.

Depends on D127384

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd5f9ce8a831
Part 1 - Remove unused kNoFlags in nsPlainTextSerializer.cpp. r=mbrodesser
https://hg.mozilla.org/integration/autoland/rev/2a6422635d37
Part 2 - Run line wrapping algorithm only if content of current line is not empty. r=m_kato,mbrodesser
https://hg.mozilla.org/integration/autoland/rev/b06880832da2
Part 3 - Consolidate logic dealing with and without aLineBreaker in FindWrapIndexForContent(). r=m_kato
https://hg.mozilla.org/integration/autoland/rev/6f0a6fcd5f5e
Part 4 - Allow GetUnicharStringWidth() to support mozilla::Span substring argument. r=m_kato
https://hg.mozilla.org/integration/autoland/rev/f7f60a86bf47
Part 5 - Simply line wrapping logic involving line breaker in FindWrapIndexForContent(). r=m_kato

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb78120056f6
Backed out 5 changesets for causing build windows bustages CLOSED TREE

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 5 changesets (Bug 1733876) for causing build windows bustages CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f7f60a86bf4764c5f376d3d41382f8f3b6481950&selectedTaskRun=HQbFe79lQ3WZOt8Kz1Tn9A.0

Log: https://treeherder.mozilla.org/logviewer?job_id=354025941&repo=autoland&lineNumber=17330

Backout: https://hg.mozilla.org/integration/autoland/rev/eb78120056f67fa51e8153039909d98f5d160087

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c7ea057db25
Part 1 - Remove unused kNoFlags in nsPlainTextSerializer.cpp. r=mbrodesser
https://hg.mozilla.org/integration/autoland/rev/dd3ea0d8556f
Part 2 - Run line wrapping algorithm only if content of current line is not empty. r=m_kato,mbrodesser
https://hg.mozilla.org/integration/autoland/rev/9fc206a0b925
Part 3 - Consolidate logic dealing with and without aLineBreaker in FindWrapIndexForContent(). r=m_kato
https://hg.mozilla.org/integration/autoland/rev/d8baa8f2e4c6
Part 4 - Allow GetUnicharStringWidth() to support mozilla::Span substring argument. r=m_kato
https://hg.mozilla.org/integration/autoland/rev/7f1e13c8839d
Part 5 - Simply line wrapping logic involving line breaker in FindWrapIndexForContent(). r=m_kato

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5c7ea057db25
https://hg.mozilla.org/mozilla-central/rev/dd3ea0d8556f
https://hg.mozilla.org/mozilla-central/rev/9fc206a0b925
https://hg.mozilla.org/mozilla-central/rev/d8baa8f2e4c6
https://hg.mozilla.org/mozilla-central/rev/7f1e13c8839d