1733195 - Merging popup windows!

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[juraj.masiar]

Attachment: merging_popup_windows.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Now, this is a bug you don't see every day! :)

Using Beta 93.0b5 (64-bit) in Win:

1. install two addons with popup windows, for example:
   https://addons.thunderbird.net/addon/web_translate/
   https://addons.thunderbird.net/addon/scroll_anywhere/
2. click on one toolbar icon
3. click-and-move (few pixels) on the second toolbar icon (like you are trying to drag it)
4. click the first icon again

Actual results:

Popup windows of both addons will be displayed :o

Expected results:

In Firefox, the click-and-move in the step 3. will open the popup. That would probably prevent the merging the step 4.

Comment 1

[John Bieling (:TbSync)]

Sure this is Beta 93? Looks like Daily 94 to me.

Comment 2

[juraj.masiar]

The video is from 94 (my testing setup), but I can reproduce it in my personal 93 as well.

Comment 3

[John Bieling (:TbSync)]

Is this limited to browser_actions, or does it also happen with compose_actions or message_display_actions?

Comment 4

[juraj.masiar]

Attachment: Screenshot 2021-09-29 23.17.17.png

Yeah, that's right, you can actually "compose" them with message action :D.
Also, I can reproduce it also in release version 91.

Comment 5

[Wayne Mery (:wsmwk)]

juraj, are you seeing this with the current beta version?

Comment 6

[juraj.masiar]

I can reproduce it in Alpha 106.0a1 (2022-09-04) (64-bit).

Comment 7

[John Bieling (:TbSync)]

Attachment: Bug 1733195 - Fix merging popups. r=freaktechnik

Comment 8

[John Bieling (:TbSync)]

try: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=b100b3349d6b57dfd91e3d1c7a4052a9fa7ae92a

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4ed785e5866b
Fix merging popups. r=freaktechnik

Comment 10

[John Bieling (:TbSync)]

Comment on attachment 9322986 [details]
Bug 1733195 - Fix merging popups. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #):
Introduction of Fission related changes prior to TB91

User impact if declined:
Opening two popups one after the other will merge them into a single popup.

Testing completed (on c-c, etc.):
Just landed, but it is a simple change and I would like to see it on beta real soon.

Risk to taking this patch (and alternatives if risky):
Should be none.

Comment 11

[John Bieling (:TbSync)]

@uraj.masiar: This has landed in Daily, could you check if this is fixed for you?

Comment 12

[juraj.masiar]

Well, I've been trying to reproduce it now in the old "Daily" but it's much harder already, the original STR doesn't work anymore.
After updating Daily I can't reproduce it anymore, I think...

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9322986 [details]
Bug 1733195 - Fix merging popups. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 14

[Daniel Darnell [:dandarnell]]

Thunderbird 112.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/0cdc6fdd3219

Comment 15

[John Bieling (:TbSync)]

Comment on attachment 9322986 [details]
Bug 1733195 - Fix merging popups. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #):
Introduction of Fission related changes prior to TB91

User impact if declined:
Opening two popups one after the other will merge them into a single popup.

Testing completed (on c-c, etc.):
Just landed on beta and is confirmed fixed. It is a very simple change.

Risk to taking this patch (and alternatives if risky):
Should be none.

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9322986 [details]
Bug 1733195 - Fix merging popups. r=freaktechnik

[Triage Comment]
Approved for esr102

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 102.9.1:
https://hg.mozilla.org/releases/comm-esr102/rev/20063e10810e