1733263 - Fire ACTIVE state change events

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task, P3)

Description

[Eitan Isaacson [:eeejay]]

I don't think we care about the root accessible case since that shouldn't happen in remote content.

We do care about aria-activedescendant though..

Comment 1

[Eitan Isaacson [:eeejay]]

Changing severity to S3 because this is ongoing cache the world work that does not affect current users.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1733263 - P1: Refactor state change event promises. r?Jamie

We do this in a bunch of places, so I moved it into promisified-events.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1733263 - P2: Flush events and notifications when waiting for unexpected events. r?Jamie

By allowing async DOM events to be dispatched, and advancing the refresh
driver we can force some calls to NotificationController::WillRefresh
and flush out any pending notifications or events.

This lets us more reliably catch unexpected events without the need for
a sentinel event at the end.

Depends on D130294

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1733263 - P3: Fire ACTIVE state change when aria-activedescendant changes. r?Jamie

Have ARIAActiveDescendantIDMaybeMoved call ARIAActiveDescendantChanged regardless of
widget focus state. The latter already checks if the widget is focused. This gives us
a chance to fire and ACTIVE state change regardless of focus state.

If an id or aria-activedescendant attribute is about to change, fire an
ACTIVE state change on the previously active accessible.

Depends on D130295

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1733263 - P4: Promisify the select focus change test. r?Jamie

This will make it easier to work with in a later change.

Depends on D130296

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1733263 - P5: Rely on DOMMenuItem events for ACTIVE state changes in select elements. r?Jamie

1. Use dom events in RootAccessible to fire ACTIVE state changes.
2. Add DOMMenuItemInactive events to nsListControlFrame and fire it on
   the previously active option.
3. Don't fire those DOM events on collapsed combo boxes.
4. Add ACTIVE state change events for collapsed combo box options.

Depends on D130297

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/439e821c9640
P1: Refactor state change event promises. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/0b3d68cb6e68
P2: Flush events and notifications when waiting for unexpected events. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/2b1755721a8e
P3: Fire ACTIVE state change when aria-activedescendant changes. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/c8f226476a30
P4: Promisify the select focus change test. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/06263018f1f7
P5: Rely on DOMMenuItem events for ACTIVE state changes in select elements. r=Jamie

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb93690f7303
Backed out 5 changesets for causing leakes. CLOSED TREE

Comment 9

[Atila Butkovits]

Backed for causing leakes.

Backout link: https://hg.mozilla.org/integration/autoland/rev/fb93690f7303b09fc8ae2f94e65c3fa3f6a10f39

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=S6BWdRZPS1yUnPhxs6xKPQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=06263018f1f70ceb780dff123c581c58c64d24e7

Failure log: https://treeherder.mozilla.org/logviewer?job_id=357578696&repo=autoland&lineNumber=2577

Comment 10

[Eitan Isaacson [:eeejay]]

I just rebased on central, tried to reproduce this locally and in try, and that specific task passes with no problem:
https://treeherder.mozilla.org/jobs?repo=try&revision=847c983bc6d4a93cb7257ef4c82f22b59b06a67c&selectedTaskRun=cRKD2kBaTKSnRtVwbiu-5A.0

I can't think of anything in the patch that would cause a JSRuntime leak.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6ea433343d6
P1: Refactor state change event promises. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/d501ebf13af2
P2: Flush events and notifications when waiting for unexpected events. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/d6b82d560ad6
P3: Fire ACTIVE state change when aria-activedescendant changes. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/edcc0183f30d
P4: Promisify the select focus change test. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/1685016c0c79
P5: Rely on DOMMenuItem events for ACTIVE state changes in select elements. r=Jamie

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f6ea433343d6
https://hg.mozilla.org/mozilla-central/rev/d501ebf13af2
https://hg.mozilla.org/mozilla-central/rev/d6b82d560ad6
https://hg.mozilla.org/mozilla-central/rev/edcc0183f30d
https://hg.mozilla.org/mozilla-central/rev/1685016c0c79