1744053 - DOMMenuItemActive/Inactive incorrectly dispatched to content

Status: NEW

(Core :: Disability Access APIs, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: testcase

These events should not be exposed to websites.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

[Tracking Requested - why for this release]: Unexpectedly web-exposed change.

Comment 2

[Eitan Isaacson [:eeejay]]

I don't think that is the correct regressing bug. I found the last build without that change, and I am still able to reproduce the testcase.

$ mozregression --launch 20211111045525

It looks like ChromeOnlyDispatch is "no" here: https://searchfox.org/mozilla-central/source/layout/generic/nsIFrame.cpp#4394

Trying to investigate how far back that goes, looks like it is pre cvs->hg migration. My hunch is that at some point those were chrome-only events judging by bug 481688.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Ah yeah, sorry, I was going through this code for bug 1744009 and saw the bogus code, and checking out blame pointed to your change. I guess your patch made us dispatch DOMMenuItemInactive events as well, but you're right that the *Active ones were already dispatched... Oof, that's quite unfortunate :(

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1733263

Comment 5

[Dianna Smith [:diannaS]]

Is this something you still want to fix?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Yeah but swamped with other things atm.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1733263