1733398 - Low contrast in the text on the URL bar with the Alpenglow theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[alex_mayorga]

¡Hola y'all!

Happy 🌮 Thursday!

Seems like when selecting text in the Awesome bar now the contrast is not great.

¡Gracias!
Alex

Comment 1

[alex_mayorga]

Attachment: image.png

Comment 2

[alex_mayorga]

Attachment: image.png

Comment 3

[Pablo]

came across this bug today when testing nightly 94 on windows 10
It shows the same when i enable the search bar in toolbar.

Nightly is affected.
Beta93 and Release 92.0.1 are not

thanks for opening it.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

For my own reference this is what I came up with to unblend the semi-transparent highlight color:

function unblendChannel(bg, fg, targetAlpha) {
  return (fg * 255 - bg * (255 - targetAlpha)) / targetAlpha 
}

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1733398 - Use subtler dark selection colors. r=dholbert,mstange

This does the same as Android and macOS (using a semi-transparent
highlight background, and currentColor for the foreground).

This is really sort of a theming issue (where the theme
mixes system colors with theme colors).

But leaving the existing selection color is prettier
even in the dark theme, so let's do that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09e0a0961e16
Use subtler dark selection colors. r=mstange

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/09e0a0961e16

Comment 8

[Mathew Hodson]

Last good revision: edb7b0ca847baac1ebc8c79f056c4ee08d0a480f
First bad revision: e6687d345d537ca669921fa18cc72e399b6a83b2
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=edb7b0ca847baac1ebc8c79f056c4ee08d0a480f&tochange=e6687d345d537ca669921fa18cc72e399b6a83b2

Could someone mark this as Regressed by bug 1731678

Comment 9

[Marco Castelluccio [:marco]]

Set release status flags based on info from the regressing bug 1731678