1733435 - Chat protocol listbox lacks clear focus indication

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot1: Where is the focus?

+++ This bug was initially created as a clone of Bug #1729948 +++

Richard, what do you think?

STR

1. ≡ > New > Chat Account --> Chat Account Wizard
2. Observe chat Network selector looking for hints of focus

Actual (see screenshot)

• no clear hints of focus - list selector looks disabled (more so with over-salient blue primary button)
• light grey is not a focus color
• Missing blue (or dotted) focus border

Expected

• Default indication of focus in default theme afasik needs blue
• Blue background for selected item
• Blue focus border for focused item

Comment 1

[Patrick Cloke [:clokep]]

Isn't this just that the default focus is on the "Next" button, not the listbox? I don't think this is a theming issue.

Comment 2

[Patrick Cloke [:clokep]]

(In reply to Patrick Cloke [:clokep] from comment #1)

Isn't this just that the default focus is on the "Next" button, not the listbox? I don't think this is a theming issue.

Oh, I see even if you click on one of the protocols it still shows up as grey, that is quite odd!

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1733435-richlistitem-themed.patch

With default theme we shouldn't set a background colour for the richlistitem.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9243781 [details] [diff] [review]
1733435-richlistitem-themed.patch

Review of attachment 9243781 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
I can't test this on dark theme as themes are currently busted on trunk.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b6f140167a8d
Style in themeableDialog.css the richlistitem only when a theme is active. r=aleca

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9243781 [details] [diff] [review]
1733435-richlistitem-themed.patch

[Approval Request Comment]
User impact if declined: not correct highlight colour in richlistists
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9243781 [details] [diff] [review]
1733435-richlistitem-themed.patch

[Triage Comment]
Approved for esr91

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/5fa10204238c