1733535 - Replace OS.File with IOUtils in the attribution code

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task)

Description

[Mark Banner (:standard8)]

Using OS.File for file access is now obsolete and can be replaced by code using IOUtils. Working towards this, the attribution code is loaded on startup and accesses OS.File. Fixing this should help a little towards startup performance.

The code in question can be found here.

There is background information here about how to migrate from OS.File to IOUtils. If you have questions, please ask.

To run the tests after you've built, you can run ./mach mochitest browser/components/attribution/. You should also check ESLint before commiting: ./mach eslint browser/components/attribution/.

I'm happy to mentor this. Note this bug will be auto-assigned when the first patch is attached.

Comment 1

[Jane Kotovich (:janey)]

Hi Mark! It's looking really interesting for me, would love give it a shot!

Comment 2

[Jane Kotovich (:janey)]

Attachment: Bug 1733535 - Replace OS.File with IOUtils in the attribution code. r=Standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d63aab4e0688
Replace OS.File with IOUtils in the attribution code. r=Standard8

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on browser_AttributionCode_telemetry.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/ad7f2081d3672aef29c228c7510bbeac4d02b4e5
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=G3hmy10QSJ68I4ueHj63rw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d63aab4e0688bca6b0c2bf6ab63a036f6b0e0bcf
Failure log: https://treeherder.mozilla.org/logviewer?job_id=355752819&repo=autoland

Comment 5

[Mark Banner (:standard8)]

We took a look and undid some of the simplifications of the original patch, so that telemetry would still be reported in the same way.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d911e3a56dce
Replace OS.File with IOUtils in the attribution code. r=Standard8

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d911e3a56dce