Closed Bug 1733535 Opened 2 months ago Closed 1 month ago

Replace OS.File with IOUtils in the attribution code

Categories

(Toolkit :: Telemetry, task)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: standard8, Assigned: janey, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=js][good-next-bug])

Attachments

(1 file)

Using OS.File for file access is now obsolete and can be replaced by code using IOUtils. Working towards this, the attribution code is loaded on startup and accesses OS.File. Fixing this should help a little towards startup performance.

The code in question can be found here.

There is background information here about how to migrate from OS.File to IOUtils. If you have questions, please ask.

To run the tests after you've built, you can run ./mach mochitest browser/components/attribution/. You should also check ESLint before commiting: ./mach eslint browser/components/attribution/.

I'm happy to mentor this. Note this bug will be auto-assigned when the first patch is attached.

Hi Mark! It's looking really interesting for me, would love give it a shot!

Assignee: nobody → jenyabrentnall
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d63aab4e0688
Replace OS.File with IOUtils in the attribution code. r=Standard8

We took a look and undid some of the simplifications of the original patch, so that telemetry would still be reported in the same way.

Flags: needinfo?(jenyabrentnall)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d911e3a56dce
Replace OS.File with IOUtils in the attribution code. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.