1703357 - Write test to ensure OS.File is not imported in the startup path (before opening first browser window)

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task, P3)

Description

[Emma Malysz]

We should make sure that any future modules do not import osfile.jsm by mistake and instead use IOUtils

Comment 1

[Mark Banner (:standard8)]

I've just filed a set of mentored bugs that I think will be enough to get us in a state where we can add osfile.jsm to the deny lists in browser_startup.js for at least the "before opening first browser window" point. There may be more needed, but it is a little hard to tell at the moment.

I think we'll probably need bug 1649599 and bug 1649605 for "before first paint" - however, lets go for the earliest option first to begin to be able to block it, and we can progressively move it even later as we progress.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1703357 - Update browser_startup to prevent osfile.jsm being loaded before opening first browser window. r?florian!

Also fixes one use in XPIInstall.jsm.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4c999428d86
Update browser_startup to prevent osfile.jsm being loaded before opening first browser window. r=florian

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a4c999428d86

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for causing Bug 1736189

Backout link: https://hg.mozilla.org/integration/autoland/rev/772dfe279def087d275150ef1cc57350c05cdae2

Comment 6

[Cosmin Sabou [:CosminS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/772dfe279def087d275150ef1cc57350c05cdae2

Comment 7

[Mark Banner (:standard8)]

I'm changing where we catch to slightly later - "before handling user events", as bug 1649605 has landed since this originally landed, which clears us loading OS.File until after that.

Comment 8

[Mark Banner (:standard8)]

Unfortunately I spoke too soon and didn't wait on the try server results. There's still a few more cases before we can clear the idle section as well. I've filed bug 1745459 as a follow-up to move the block later in startup.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba147b5b6ef8
Update browser_startup to prevent osfile.jsm being loaded before opening first browser window. r=florian

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ba147b5b6ef8