1733540 - Replace OS.File with IOUtils in XPIInstall.jsm, and drop usage of osfile.jsm

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[Mark Banner (:standard8)]

Using OS.File for file access is now obsolete and can be replaced by code using IOUtils. Working towards this,XPIInstall.jsm is loaded on startup and accesses OS.File. Fixing this should help a little towards startup performance.

The code in question can be found here.

There is background information here about how to migrate from OS.File to IOUtils. If you have questions, please ask.

To run the tests after you've built, you can run ./mach xpcshell-test toolkit/mozapps/extensions/. You should also check ESLint before commiting: ./mach xpcshell-test toolkit/mozapps/extensions/.

I'm happy to mentor this. Note this bug will be auto-assigned when the first patch is attached.

Comment 1

[Tomislav Jovanovic :zombie]

Changing severity to NA because of it's a task.

Comment 2

[Mark Banner (:standard8)]

Expanding scope slightly to also include dropping osfile.jsm completely. This shouldn't be too much extra work - OS.Path.join can be replaced with PathUtils.join with no need to change the parameters.

Comment 3

[Mathew Hodson]

Attachment: Bug 1733540 - Replace osfile.jsm usage in XPIInstall.jsm. r=robwu

Comment 4

[Mathew Hodson]

Can you take another look at this? I believe I addressed the requested changes.

Comment 5

[Rob Wu [:robwu]]

Thanks.

Comment 6

[Mark Banner (:standard8)]

Mathew, thank you for working on this, it is great to get it landing. I've just triggered the landing to autoland.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0eaa9ccaaf77
Replace osfile.jsm with IOUtils/PathUtils in XPIInstall.jsm. r=robwu

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0eaa9ccaaf77

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/772dfe279def
Backed out 2 changesets (bug 1733540, bug 1703357) for causing Bug 1736189

Comment 10

[Narcis Beleuzu [:NarcisB]]

Backed out for causing Bug 1736189

Backout link: https://hg.mozilla.org/integration/autoland/rev/772dfe279def087d275150ef1cc57350c05cdae2

Comment 11

[Mark Banner (:standard8)]

Mathew, do you have access to the try server? I'm tempted to try a few things out on try server and see if we can narrow this issue down a bit.

Comment 12

[Mathew Hodson]

No I don't have access.

Comment 13

[Cosmin Sabou [:CosminS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/772dfe279def087d275150ef1cc57350c05cdae2

Comment 14

[Mark Banner (:standard8)]

This doesn't need to block bug 986145 directly, it already blocks bug 1703357 which blocks bug 986145.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34e079fbcc76
Replace osfile.jsm usage in XPIInstall.jsm. r=robwu

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/34e079fbcc76