1733556 - Add Permissions Policy support for Storage Access API

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P2)

Description

[Johann Hofmann [:johannh]]

We've recently added support for nested storage access requests to the spec, under the caveat that it can be disallowed through permissions policy allow attributes.

Would be nice to implement this for Gecko.

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1733556 - Expose "storage-access" to the Permissions Policy - r=#anti-tracking-reviewers!

Depends on D182246

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1733556 - Perform Permissions Policy check in requestStorageAccess() - r=#anti-tracking-reviewers!

Depends on D182247

Comment 3

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1733556 - Perform Permissions Policy check in navigator.permissions.query for "storage-access" - r=#anti-tracking-reviewers!

Depends on D182248

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8c19265b981
Expose "storage-access" to the Permissions Policy - r=anti-tracking-reviewers,pbz,smaug
https://hg.mozilla.org/integration/autoland/rev/6c09379cdb5a
Perform Permissions Policy check in requestStorageAccess() - r=anti-tracking-reviewers,pbz
https://hg.mozilla.org/integration/autoland/rev/fa21a55ce837
Perform Permissions Policy check in navigator.permissions.query for "storage-access" - r=anti-tracking-reviewers,pbz

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing bp-nu bustages in StorageAccessAPIHelper.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/toolkit/components/antitracking/StorageAccessAPIHelper.cpp:873:5: error: unknown type name 'FeaturePolicy'; did you mean 'dom::FeaturePolicy'?

Comment 6

[Benjamin VanderSloot [:bvandersloot]]

This is a simple fix in the compile that I will get right on.

This built successfully locally and in a try run on linux64. How can I catch errors like this before landing?

Comment 7

[Paul Zühlcke [:pbz]]

(In reply to Benjamin VanderSloot [:bvandersloot] from comment #6)

This is a simple fix in the compile that I will get right on.

This built successfully locally and in a try run on linux64. How can I catch errors like this before landing?

It's a non-unified build, you can also do that locally to verify the fix. I usually just run all the build jobs before landing via mach try fuzzy. Generally you want to make sure to get the includes right. Unified may cover up missing includes. Though here it looks like a namespace issue?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa21c5369a0c
Expose "storage-access" to the Permissions Policy - r=anti-tracking-reviewers,pbz,smaug
https://hg.mozilla.org/integration/autoland/rev/6ef3456dba87
Perform Permissions Policy check in requestStorageAccess() - r=anti-tracking-reviewers,pbz
https://hg.mozilla.org/integration/autoland/rev/b58d05168ab7
Perform Permissions Policy check in navigator.permissions.query for "storage-access" - r=anti-tracking-reviewers,pbz

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/aa21c5369a0c
https://hg.mozilla.org/mozilla-central/rev/6ef3456dba87
https://hg.mozilla.org/mozilla-central/rev/b58d05168ab7