1733959 - There should be a button or checkbox to unselect all calendars in the Caldav wizard

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, enhancement, P5)

Description

[Jérémie Parisel]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

I added a Caldav calendar through the new wizard (great! Thank you for that lovely piece of software btw).

Actual results:

I was presented with all the available calendars (about 150 in my case) all selected and ready to be subscribed to.
So I needed to manually unselect each calendar but the one I wanted to subscribe to.

Expected results:

I wish there was a way to unselect all calendars in that modal.
Like a "Unselect all" button, or a head checkbox that selects/unselects all items.

Comment 1

[Thomas D. (:thomas8)]

Hey firefox, here's your first response from Thunderbird :-)

Thanks, sounds good to me and should be doable. For users with more calendars, this may indeed be tedious. Alex' call if he's willing to add e.g. a checkbox on top to toggle select/unselect all.

• 150 calendars!? Any hints what's that good for?
• How did TB's Create New Calendar dialog scale with 150 calendars? Could you add a screenshot after covering private data?

Comment 2

[Jérémie Parisel]

Attachment: Thunderbird-150-calendars.png

Screenshot of the modal displaying many calendars available to add.
All calendars but the first one (which was already added and is greyed out) are selected.
There is a scrollbar that allow to scroll through all the available calendars.

Comment 3

[Jérémie Parisel]

The 150 calendars is because we are a non-profit with approx 100 workers and we work on a quite horizontal way, so almost everyone needs access to everyone's calendar.
Plus we have some generic calendars for meeting rooms etc..

We are considering limiting the accessibility of calendars, though.

Comment 4

[Jérémie Parisel]

(In reply to Thomas D. (:thomas8) from comment #1)

Hey firefox, here's your first response from Thunderbird :-)

Thanks, sounds good to me and should be doable. For users with more calendars, this may indeed be tedious. Alex' call if he's willing to add e.g. a checkbox on top to toggle select/unselect all.

• 150 calendars!? Any hints what's that good for?
• How did TB's Create New Calendar dialog scale with 150 calendars? Could you add a screenshot after covering private data?

Hey :thomas8.

Is there anything I can do to move this request forward?
I looked at the code base, but I'm not able to make a decent modification myself.

Comment 5

[Thomas D. (:thomas8)]

Thanks for your followup interest, Jérémie!
Let's ask Alex, our UX lead.

(In reply to Thomas D. (:thomas8) from comment #1)

Thanks, sounds good to me and should be doable. For users with more calendars, this may indeed be tedious. Alex' call if he's willing to add e.g. a checkbox on top to toggle select/unselect all.

Alex, reporter's real-life enterprise scenario has 150 available calendars (see comment 3 for explanation) which we all pre-select, but only wants to subscribe one, so unchecking all becomes a nuisance. What do you think about adding a toggle for select/unselect all to this dialog?
Would this be a "good first bug"?

Relevant code near here:
https://searchfox.org/comm-central/source/calendar/locales/en-US/chrome/calendar/calendarCreation.dtd#50
https://searchfox.org/comm-central/search?path=&q=network.subscribe.single.description
https://searchfox.org/comm-central/source/calendar/base/content/dialogs/calendar-creation.js#488

Comment 6

[Magnus Melin [:mkmelin]]

For the setup wizard, code would be around here: https://searchfox.org/comm-central/rev/d678a291f0c1c368a046944719e98164226095d9/mail/components/accountcreation/content/accountSetup.xhtml#816

I believe the standalone setup dialogs flows will soon be directed to the unified flow, inside a tab.

Comment 7

[Alessandro Castellani [:aleca]]

Indeed, the calendar dialog will be dropped and the setup flow will be part of the account hub.
If this is not urgent, we can defer it to the work on the account hub, otherwise, we can consider creating a quick patch for a global checkbox toggle we could potentially uplift for 102.

Comment 8

[Jérémie Parisel]

Thank you all 3 for your quick reaction (I was afraid of being pushy, and actually am glad I reiterated my interest).

I'm not the right person to evaluate the urgency of the change, but selfishly it would help my teams migrate to 102.
Indeed, we are currently keeping 91 since TBSync add-on is not 102-compatible but handles numerous caldavs better.

Again, thank you for your quick reaction.

Comment 9

[Jérémie Parisel]

Hello,

I see this has not been implemented yet in Daily.
And (as someone not into the development of TB), I don't see a sign of a this wizard being part of a "unifed flow".
Should I create a new bug report for this or is there a way to resurrect the current one?

Comment 10

[Alessandro Castellani [:aleca]]

No need to create a new bug.
We set a P5 priority, which means is something that we will get to it but is not a blocker.

Comment 11

[Jérémie Parisel]

I'm late to the party, but Wayne, can you please explain to me (if you have the time and energy to do so) why it has been set as wontfix?
Is this status only for ESR115? Or does it mean it won't be implemented ever?

Comment 12

[Wayne Mery (:wsmwk)]

As the flag name indicates, it is only about 115.

As an enhancement the team would not prioritize it for 115. But if someone from the community were to provide a patch, it might be accepted for 115.

Comment 13

[benedikt.kaless]

Hi,

we are a NGO working with Thunderbird a lot. We also have something like 150 - 200 calendars (each colleague has one + some for meeting rooms). Its a blocker for us to be honest that you have to deactivate 150 calendars if you want to subscribe to a new calendar.

Do you have some plans to introduce a toggle switch in 128?

Best
Benedikt

Comment 14

[Magnus Melin [:mkmelin]]

Maybe we indeed need to just add the buttons for now.

Comment 15

[Magnus Melin [:mkmelin]]

Attachment: Bug 1733959 - There should be a button or checkbox to unselect all calendars in the Caldav wizard. r=#thunderbird-front-end-reviewers

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e619a86a8475
There should be a button or checkbox to unselect all calendars in the Caldav wizard. r=tobyp

Comment 17

[Jérémie Parisel]

Thanks to [e-mail] for this contribution.

I tested it on nightly and the buttons are there and working!

Comment 18

[Alessandro Castellani [:aleca]]

(In reply to Jérémie Parisel from comment #17)

Thanks to [e-mail] for this contribution.

I tested it on nightly and the buttons are there and working!

Tiny correction, Magnus is the one that implemented the feature :D