1734360 - App Menu Attachment submenu is empty

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

Steps to Reproduce

1. Open a message with an attachment.
2. Open the app menu panel.
3. Click "Attachments".
4. Click one of the attachments.

Result

The panel is empty. And there is an error in the console

Uncaught TypeError: attachment is undefined
    _onAttachmentViewShow chrome://messenger/content/customizableui/panelUI.js:761

Expect

The panel to fill with "Open", "Save As...", etc.

Origin

I think this is caused by https://hg.mozilla.org/comm-central/rev/3d2b9c2c3285#l7.12 since restoring the line fixes this.

Comment 1

[Magnus Melin [:mkmelin]]

Thanks, can you submit a patch?

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Magnus Melin [:mkmelin] from comment #1)

Thanks, can you submit a patch?

Do you mind restoring the use of explicitOriginalTarget despite bug 1699809? I'm not sure if there would be an easy fix otherwise.

Comment 3

[Magnus Melin [:mkmelin]]

No that's fine to restore.

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1734360 - Use explicitOriginalTarget again in panelUI _onAttachmentViewShow. r=mkmelin

This reverts the changes to panelUI.js in rev 3d2b9c2c3285 since event.explicitOriginalTarget differs from event.target in this event handler.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5ab3d8e77adf
Use explicitOriginalTarget again in panelUI _onAttachmentViewShow. r=mkmelin

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9244558 [details]
Bug 1734360 - Use explicitOriginalTarget again in panelUI _onAttachmentViewShow. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1699809
User impact if declined: Attachment item in the App Menu is empty and unusable
Testing completed (on c-c, etc.): No tests
Risk to taking this patch (and alternatives if risky): Low risk. This is just reverting a single line from https://hg.mozilla.org/comm-central/rev/3d2b9c2c3285#l7.12 which did not interact with the rest of the patch, and it was not trying to change or fix behaviour.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9244558 [details]
Bug 1734360 - Use explicitOriginalTarget again in panelUI _onAttachmentViewShow. r=mkmelin

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 94.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/2783b5a0f87e

Comment 9

[WaltS48 [:walts48]]

Verified in my testing of the 94.0b2 release candidate on Fedora 34.

Comment 10

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9244558 [details]
Bug 1734360 - Use explicitOriginalTarget again in panelUI _onAttachmentViewShow. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1699809
User impact if declined: Attachment item in the App Menu is empty and unusable
Testing completed (on c-c, etc.): Verified on 94 beta.
Risk to taking this patch (and alternatives if risky): Low risk. This is just reverting a single line from https://hg.mozilla.org/comm-central/rev/3d2b9c2c3285#l7.12 which did not interact with the rest of the patch, and it was not trying to change or fix behaviour.

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9244558 [details]
Bug 1734360 - Use explicitOriginalTarget again in panelUI _onAttachmentViewShow. r=mkmelin

[Triage Comment]
Approved for ers91

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/6c25b71591e1