1734461 - Also check and reset newtab pref from "Firefox Home" upgrade spotlight checkbox

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Original requirement for MR2 onboarding was to reset home page to "Firefox Home" but we can also convert users who have set new tab to blank.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1734461 - Also check and reset newtab pref from "Firefox Home" upgrade spotlight checkbox r?pdahiya

Add newtab pref checks and record events for when checkbox button is handled. Split up trigger tests to own file and share telemetry helpers from head.js.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/147fa67c0667
Also check and reset newtab pref from "Firefox Home" upgrade spotlight checkbox r=pdahiya

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/147fa67c0667

Comment 4

[Ed Lee :Mardak]

Comment on attachment 9244638 [details]
Bug 1734461 - Also check and reset newtab pref from "Firefox Home" upgrade spotlight checkbox r?pdahiya

Beta/Release Uplift Approval Request

• User impact if declined: Upgrade spotlight only updates about:preferences customized home page instead of also newtab to show Firefox Home (with the new MR2 theming)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Change about:preferences newtab pref (show blank)

2. Open upgrade spotlight
3. Go to colorway screen with checkbox
4. Keeping it checked and finishing the screen makes new tab show Firefox Home

• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Add simple check for both about:newtab pref and about:home pref instead of just the latter
• String changes made/needed: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244638 [details]
Bug 1734461 - Also check and reset newtab pref from "Firefox Home" upgrade spotlight checkbox r?pdahiya

Approved for 94.0b5.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8b9942d405e0

Comment 7

[Robert Martin [:romartin], Ecosystem QA]

Marking this issue as Verified based on the work done for the feature. For more information see QA-1202.