Closed Bug 1734461 Opened 4 months ago Closed 4 months ago

Also check and reset newtab pref from "Firefox Home" upgrade spotlight checkbox

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
95 Branch
Iteration:
95.1 - Oct 4 - Oct 17
Tracking Status
firefox94 + verified
firefox95 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Original requirement for MR2 onboarding was to reset home page to "Firefox Home" but we can also convert users who have set new tab to blank.

Priority: -- → P1
Depends on: 1728854

Add newtab pref checks and record events for when checkbox button is handled. Split up trigger tests to own file and share telemetry helpers from head.js.

Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/147fa67c0667
Also check and reset newtab pref from "Firefox Home" upgrade spotlight checkbox r=pdahiya
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Blocks: 1734834

Comment on attachment 9244638 [details]
Bug 1734461 - Also check and reset newtab pref from "Firefox Home" upgrade spotlight checkbox r?pdahiya

Beta/Release Uplift Approval Request

  • User impact if declined: Upgrade spotlight only updates about:preferences customized home page instead of also newtab to show Firefox Home (with the new MR2 theming)
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Change about:preferences newtab pref (show blank)
  1. Open upgrade spotlight
  2. Go to colorway screen with checkbox
  3. Keeping it checked and finishing the screen makes new tab show Firefox Home
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Add simple check for both about:newtab pref and about:home pref instead of just the latter
  • String changes made/needed: none
Attachment #9244638 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9244638 [details]
Bug 1734461 - Also check and reset newtab pref from "Firefox Home" upgrade spotlight checkbox r?pdahiya

Approved for 94.0b5.

Attachment #9244638 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Marking this issue as Verified based on the work done for the feature. For more information see QA-1202.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.