1734586 - After using the tab context menu, the chat tooltip does not show

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

Steps to reproduce

1. Open Chat.
2. Hover over a contact to see the chat tooltip.
3. Open the context menu of a tab.
4. Hover over the same contact.

Result

No tooltip shows.

Expect

The same tooltip

Origin

The tab element sets document.popupNode when the context menu is shown. This is never unset. The chat tooltip method is the only place (outside of suite) that checks for this property (https://searchfox.org/comm-central/rev/bbe4fa02ba9884831453c336de90fb840a7185e6/chat/content/chat-tooltip.js#81)

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1734586 - Drop document.popupNode. r=freaktechnik

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/98c46a7aa380
Drop document.popupNode. r=freaktechnik

Comment 3

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9244734 [details]
Bug 1734586 - Drop document.popupNode. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: The chat tooltip will not show for the rest of the session if they ever use the tab context menu.
Testing completed (on c-c, etc.): None
Risk to taking this patch (and alternatives if risky): Low risk. This just gets rid of the two left over usages of document.popupNode, which wasn't used for anything else.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9244734 [details]
Bug 1734586 - Drop document.popupNode. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 94.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/b94dc08efc91

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9244734 [details]
Bug 1734586 - Drop document.popupNode. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: The chat tooltip will not show for the rest of the session if they ever use the tab context menu.
Testing completed (on c-c, etc.): None.
Risk to taking this patch (and alternatives if risky): Low risk. This just gets rid of the two left over usages of document.popupNode, which wasn't used for anything else.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9244734 [details]
Bug 1734586 - Drop document.popupNode. r=freaktechnik

[Triage Comment]
Approved for esr91

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 91.3.0:
https://hg.mozilla.org/releases/comm-esr91/rev/10c1d04bcdff

Comment 9

[Rob Lemley [:rjl]]

Backout due to bad merge:
https://hg.mozilla.org/releases/comm-esr91/rev/98daf2e68915

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 91.3.0:
https://hg.mozilla.org/releases/comm-esr91/rev/8f79883cbae8