Bookmark star color is different between Urlbar and one-offs
Categories
(Firefox :: Theme, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox-esr91 | --- | unaffected |
| firefox93 | --- | unaffected |
| firefox94 | --- | fixed |
| firefox95 | --- | verified |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-theme])
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
|
Details | Review |
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
This variable is also referenced in #star-button[starred].
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Comment 2•3 years ago
|
||
Set release status flags based on info from the regressing bug 1731660
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/04772ce6f746 Unify Urlbar bookmark star colors. r=dao,amy
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
|
||
Comment 5•3 years ago
|
||
The issue is verified fixed using the latest nightly on Windows 10, Ubuntu 20 and macOS 10.15. The bookmark icon has the same color in the address bar and one-off section.
Will set it to verified after the check is done on beta as well.
|
|
||
Updated•3 years ago
|
|
|
||
Comment 6•3 years ago
|
||
The patch landed in nightly and beta is affected.
:harry, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Comment 7•3 years ago
|
||
Comment on attachment 9244790 [details]
Bug 1734646 - Unify Urlbar bookmark star colors. r?dao,amy
Beta/Release Uplift Approval Request
- User impact if declined: Some elements in the address bar (reader mode icon, bookmark stars) will have the wrong color when the new monochromatic themes are applied.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very small CSS-only change. No issues after 5 days in Nightly.
- String changes made/needed:
|
||
Comment 8•3 years ago
|
||
Comment on attachment 9244790 [details]
Bug 1734646 - Unify Urlbar bookmark star colors. r?dao,amy
Approved for 94.0b6
|
||
Comment 9•3 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
Description
•