1731660 - Theme notification badges, tab throbber, and attention color

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Harry Twyford]

The Figma spec calls for app menu badges, tab throbber, and the attention color to be themed. The attention color is the color used primarily in the bookmarks star and download icon.

One tricky part of this bug will be that the "Balanced" themes call for two attention colors: one for light backgrounds (bookmarks star in the address bar, tab throbber in the active tab), and one for dark backgrounds (download icon, app menu notification). We'll need to refactor some CSS to enable this.

Comment 3

[Harry Twyford]

Attachment: Bug 1731660 - Theme notification badges, tab throbber, and attention color. r?dao!

There are a few slight changes to other properties. These are ridealongs, and a result of UX updating the colors in the Figma spec. Those changes are included in the Figma export, so they get pulled in when I create new manifests with my script. Here are the script changes for this bug: https://github.com/htwyford/create-theme-script/pull/2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a97f6a6d4ed
Theme notification badges, tab throbber, and attention color. r=dao

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2a97f6a6d4ed

Comment 6

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: bookmark different color & hover issue

Re-opening the issue, because as mentioned, for all balanced themes seem to cause an issue.
More specific, the bookmark icon from the address bar and the bookmark icon from the address bar drop-down (search shortcuts section), have different colors. Here are the steps:

1. Launch Firefox.
2. Enable any balanced theme.
3. Go to a website and bookmark it.
4. Click on the address bar in order to expand it and compare the bookmark icons.

AR: Bookmark icon has different colors.
ER: Bookmark icon has the same color.

Please note that there is also the issue of visibility in the current implementation. Hovering over the bookmark shortcut in the address bar dropdown makes the icon barely visible.

Please see the attached screenshots for more details.

Comment 7

[Harry Twyford]

Filed in bug 1734646.