1734674 - The toggle button style of Personalize new tab is different from addons manager with Dark Theme

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Alice0775 White]

Attachment: image.png

Steps To Reproduce:

1. Enable Dark Theme

2. Install any addon

3. Disable the addon

4. Observe the style of the toggle button

5. Open New Tab

6. Click Personalize new tab gear icon

7. Disable any category

8. Observe the style of the toggle button

Actual Results:
The circle styles are different

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=462b8ab0d119d85c044a1332446b609786fcabc7&tochange=4d1d81ae7b7edc5668d65b6927d907feab8d0e21

Comment 2

[Mark Striemer [:mstriemer]]

There are styles that can be reused in toggle-button.css [1] on the new tab, but including the needed colours from common.css breaks the layout. The necessary colours could be manually added to the page if necessary.

[1] https://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/toggle-button.css

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1727319

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:amy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 7

[Hanna Jones [:hjones]]

This should be covered by Bug 1812135 which we recently landed a fix for. The new tab personalization panel and about:addons are now using the same custom element for their toggles.

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Beta 120.0b5 (Build ID: 20231101092803) installed on Windows 10 x64, macOS 13.4.1, and Linux Mint 21.1. I can confirm that the toggle button style from the "Personalize New Tab" is similar to the one from the add-ons manager if the browser's Dark theme is enabled.