Replace existing new tab variables with a more limited set
Categories
(Firefox :: New Tab Page, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox94 | --- | verified |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
(Whiteboard: [fidefe-theme])
Attachments
(3 files)
This is the follow-up bug to bug 1727317. We should replace the hundreds of existing new tab variables with the limited set of colors defined in that bug. For example, say we define two box-shadow variables in bug 1727317, one for small elements and another for big elements. In this bug, we should audit the dozens of box-shadows currently in use and replace them with either the big-element box-shadow or the small-element box-shadow.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
While this is mainly a refactoring patch, a few visible effects are expected:
- Proton Primary teal is now used correctly in dark mode. I confirmed with UX that we want this.
- Various minor elements now may use slightly different colors than before. Things like hover states and borders are now functions of the main colors on the page rather than their own hardcoded colors. While one might be able to spot differences in a side-by-side comparison, the general idea is to capture the same "feeling".
Depends on D125606
Assignee | ||
Comment 2•3 years ago
|
||
Depends on D125607
Assignee | ||
Comment 3•3 years ago
|
||
Depends on D125608
Assignee | ||
Comment 4•3 years ago
|
||
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0e86a4365dad
https://hg.mozilla.org/mozilla-central/rev/131f2728359c
https://hg.mozilla.org/mozilla-central/rev/4d1d81ae7b7e
Assignee | ||
Updated•3 years ago
|
Comment 7•3 years ago
|
||
This issue was part of the work done on QA-1182 request. Considering this I am marking it as Verified.
Description
•