1727319 - Replace existing new tab variables with a more limited set

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Harry Twyford]

This is the follow-up bug to bug 1727317. We should replace the hundreds of existing new tab variables with the limited set of colors defined in that bug. For example, say we define two box-shadow variables in bug 1727317, one for small elements and another for big elements. In this bug, we should audit the dozens of box-shadows currently in use and replace them with either the big-element box-shadow or the small-element box-shadow.

Comment 1

[Harry Twyford]

Attachment: Bug 1727319 - Assign set of colors from bug 1727317 to the existing new tab CSS variables. r?thecount!,mardak

While this is mainly a refactoring patch, a few visible effects are expected:

• Proton Primary teal is now used correctly in dark mode. I confirmed with UX that we want this.
• Various minor elements now may use slightly different colors than before. Things like hover states and borders are now functions of the main colors on the page rather than their own hardcoded colors. While one might be able to spot differences in a side-by-side comparison, the general idea is to capture the same "feeling".

Depends on D125606

Comment 2

[Harry Twyford]

Attachment: Bug 1727319 - Part 2 - Remove intermediary variables in _theme.scss. r?thecount!,mardak

Depends on D125607

Comment 3

[Harry Twyford]

Attachment: Bug 1727319 - Part 3 - Remove unused hardcoded colors in _variables.scss. r?thecount!,mardak

Depends on D125608

Comment 4

[Harry Twyford]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=130826d6aaa405aacbe1c2f79b2bfbf759932ca5

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e86a4365dad
Assign set of colors from bug 1727317 to the existing new tab CSS variables. r=Mardak
https://hg.mozilla.org/integration/autoland/rev/131f2728359c
Part 2 - Remove intermediary variables in _theme.scss. r=Mardak
https://hg.mozilla.org/integration/autoland/rev/4d1d81ae7b7e
Part 3 - Remove unused hardcoded colors in _variables.scss. r=Mardak

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0e86a4365dad
https://hg.mozilla.org/mozilla-central/rev/131f2728359c
https://hg.mozilla.org/mozilla-central/rev/4d1d81ae7b7e

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

This issue was part of the work done on QA-1182 request. Considering this I am marking it as Verified.