1734687 - Fix mochitest-plain tests that break with download improvements pref flipped to true

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, task, P1)

Description

[:Gijs (he/him)]

uriloader/exthandler/tests/mochitest/test_invalidCharFileExtension.xhtml
uriloader/exthandler/tests/mochitest/test_nullCharFile.xhtml
uriloader/exthandler/tests/mochitest/test_unsafeBidiChars.xhtml

are all sad, and all for the same reason.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1734687 - fix mochitest plain tests to pass with/without improvements_to_downloads changes, r?mhowell

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a54d16de0c1
fix mochitest plain tests to pass with/without improvements_to_downloads changes, r=mhowell

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 4a54d16de0c1 (Bug 1734687) for causing failures in test_nullCharFile.xhtml

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4a54d16de0c15200de6bb58a3f95436087290e18&selectedTaskRun=Buw9OsHmQBCzxR-jewutgQ.0

Log: https://treeherder.mozilla.org/logviewer?job_id=354071687&repo=autoland&lineNumber=1887

Backout: https://hg.mozilla.org/integration/autoland/rev/6d54f255580f3326bf3f8307404170817af3cc6b

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c15b48000571
fix mochitest plain tests to pass with/without improvements_to_downloads changes, r=mhowell

Comment 5

[Cristian Tuns]

Backed out for causing mochitest failures on test_nullCharFile.xhtml

• Backout link
• Push with failures
• Failure Log

Comment 6

[:Gijs (he/him)]

Gah, this is annoying. https://treeherder.mozilla.org/jobs?repo=try&revision=58d727fbcf6b23d12659712b3f71d35d03901513 looks to be happier, will repush tomorrow if nothing turns orange...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6de8d791402f
fix mochitest plain tests to pass with/without improvements_to_downloads changes, r=mhowell

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6de8d791402f