1724319 - Fix test failures when browser.download.improvements_to_download_panel pref is true

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, task, P3)

Description

[Micah [:mtigley] (she/her)]

This issue is for identifying test failures when the browser.download.improvements_to_download_panel pref is true.

Comment 1

[Micah [:mtigley] (she/her)]

Attachment: Bug 1724319 - Fix failing tests in browser/base/content/general when new downloads pref is enabled. r?Gijs

Comment 2

[Release mgmt bot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mtigley, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[:Gijs (he/him)]

I'm not sure why this hasn't landed, I'll let Micah answer this when she's back from PTO.

Comment 4

[Micah [:mtigley] (she/her)]

This patch hasn't landed yet since the test needs to be adjusted to cleanup any created .part files.

Comment 5

[kpatenio]

Attachment: Bug 1724319 - Fix tests in toolkit/mozapps/downloads/test + browser_first_download_panel.js when download pref enabled. r=mtigley!

Comment 6

[kpatenio]

Attachment: Bug 1724319 - Fix browser_test_data_download when improvement downloads pref is true r=mtigley!

Comment 7

[Micah [:mtigley] (she/her)]

Attachment: Bug 1724319 - Fix remaining failing tests in browser/components/downloads/test/browser. r=mhowell

Comment 8

[kpatenio]

Attachment: Bug 1724319 - fix browser_test_data_text_csv when downloads pref is true. r=mtigley!

Comment 9

[kpatenio]

Attachment: Bug 1724319 - fix browser_open_internal_choice_persistence when downloads pref is enabled. r=mtigley!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0926e8e7148
Fix tests in toolkit/mozapps/downloads/test + browser_first_download_panel.js when download pref enabled. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/75a253b872d4
Fix remaining failing tests in browser/components/downloads/test/browser. r=mhowell

Comment 11

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing failures on browser_download_overwrite.js. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/f8b4a8e59e4e0e2f1b38a8535f9af44279af363f
Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=CikCToF7RbGNH2sZa7pulw.0&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-browser-chrome-swr-e10s%2Cbc1&revision=75a253b872d49bc6a43fef3862e399861c0e184e
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=351489228&repo=autoland&lineNumber=2791

Comment 12

[Micah [:mtigley] (she/her)]

(In reply to Cristina Cozmuta (:CrissCozmuta) from comment #11)

Backed out for causing failures on browser_download_overwrite.js. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/f8b4a8e59e4e0e2f1b38a8535f9af44279af363f
Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=CikCToF7RbGNH2sZa7pulw.0&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-browser-chrome-swr-e10s%2Cbc1&revision=75a253b872d49bc6a43fef3862e399861c0e184e
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=351489228&repo=autoland&lineNumber=2791

It looks like the failures are related to just browser_download_overwrite.js. It seems to only happen on Linux 18.04 with WebRender enabled...which I'm not sure why yet.

In the meantime, I'll go ahead and land the first part of this patch queue.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48fac2760660
Fix tests in toolkit/mozapps/downloads/test + browser_first_download_panel.js when download pref enabled. r=mtigley

Comment 14

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/48fac2760660

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/407b3b199382
Fix remaining failing tests in browser/components/downloads/test/browser. r=mhowell

Comment 16

[Molly Howell (she/her) [:mhowell]]

Attachment: Bug 1724319 - Fix test_handlerService_store.js when new download changes are enabled. r=mtigley

Comment 17

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/407b3b199382

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/033836060d50
Fix test_handlerService_store.js when new download changes are enabled. r=mtigley

Comment 19

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/033836060d50

Comment 20

[Molly Howell (she/her) [:mhowell]]

Attachment: Bug 1724319 - Fix toolkit downloads component tests for when new download changes are enabled. r=mtigley

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c5fe2e40cc5
Fix toolkit downloads component tests for when new download changes are enabled. r=mtigley

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b69342ce707
fix browser_test_data_text_csv when downloads pref is true. r=mtigley

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d60211f20840
Fix browser_test_data_download when improvement downloads pref is true r=mtigley

Comment 24

[Natalia Csoregi [:nataliaCs]]

Backed out 0b69342ce707 for failures on browser_test_data_text_csv

• backout: https://hg.mozilla.org/integration/autoland/rev/fe7fd9b31da5356183e5e45c0b20a686c821db86

• push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=NZbUdyP1SHq1cUOElWHwiw.0&revision=0b69342ce7070c4eb2b2445e1414819947cc973f&group_state=expanded

• tier 1 failure appeared on a subsequent push

• failure log: https://treeherder.mozilla.org/logviewer?job_id=352168160&repo=autoland&lineNumber=3887

[task 2021-09-20T23:32:31.275Z] 23:32:31     INFO - TEST-PASS | dom/security/test/general/browser_test_data_text_csv.js | file name of download should match - 
[task 2021-09-20T23:32:31.275Z] 23:32:31     INFO - Leaving test bound test_with_downloads_improvement_pref_disabled
[task 2021-09-20T23:32:31.276Z] 23:32:31     INFO - Entering test bound test_with_downloads_improvement_pref_enabled
[task 2021-09-20T23:32:31.276Z] 23:32:31     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/dom/security/test/general/file_data_text_csv.html" line: 0}]
[task 2021-09-20T23:32:31.277Z] 23:32:31     INFO - Buffered messages finished
[task 2021-09-20T23:32:31.278Z] 23:32:31     INFO - TEST-UNEXPECTED-FAIL | dom/security/test/general/browser_test_data_text_csv.js | Test timed out - 
[task 2021-09-20T23:32:31.279Z] 23:32:31     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-09-20T23:32:31.279Z] 23:32:31     INFO - TEST-UNEXPECTED-FAIL | dom/security/test/general/browser_test_data_text_csv.js | Uncaught exception received from previously timed out test - popupshown listener on #downloadsPanel not removed before the end of test
[task 2021-09-20T23:32:31.279Z] 23:32:31     INFO - GECKO(2628) | MEMORY STAT | vsize 3052MB | residentFast 318MB | heapAllocated 191MB
[task 2021-09-20T23:32:31.279Z] 23:32:31     INFO - TEST-OK | dom/security/test/general/browser_test_data_text_csv.js | took 45009ms

Comment 25

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8c5fe2e40cc5
https://hg.mozilla.org/mozilla-central/rev/d60211f20840

Comment 26

[Micah [:mtigley] (she/her)]

(In reply to Natalia Csoregi [:nataliaCs] from comment #24)

Backed out 0b69342ce707 for failures on browser_test_data_text_csv

• backout: https://hg.mozilla.org/integration/autoland/rev/fe7fd9b31da5356183e5e45c0b20a686c821db86

• push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=NZbUdyP1SHq1cUOElWHwiw.0&revision=0b69342ce7070c4eb2b2445e1414819947cc973f&group_state=expanded

• tier 1 failure appeared on a subsequent push

• failure log: https://treeherder.mozilla.org/logviewer?job_id=352168160&repo=autoland&lineNumber=3887

I suspect we're not cleaning up properly in the previous test dom\security\test\general\browser_test_data_download.js. I've checked out a recent pull from central with this patch applied and it looks like we're getting a new failure when running the whole test directory:

dom/security/test/general/browser_test_data_download.js
  FAIL Uncaught exception - at chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_download.js:108 - TypeError: can't access property Symbol.iterator, downloads._downloads is undefined
Stack trace:
test_with_downloads_pref_enabled@chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_download.js:108:20
dom/security/test/general/browser_test_data_text_csv.js
  FAIL File contentType should be correct. - Got "text/html", expected "text/csv"
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1364
chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_text_csv.js:test_with_downloads_improvement_pref_enabled:81
  FAIL File name should be correct. - Got "data:text/html,<body>data download</body>", expected "data:text/csv;foo,bar,foobar"
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1364
chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_text_csv.js:test_with_downloads_improvement_pref_enabled:82

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56a4ee0d1065
fix browser_test_data_text_csv when downloads pref is true. r=mtigley

Comment 28

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/56a4ee0d1065

Comment 29

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1724319 - Fix pdfjs component tests for when new download changes are enabled. r?Gijs!

Comment 30

[Molly Howell (she/her) [:mhowell]]

Attachment: Bug 1724319 - Stop this test from depending on the download modal for starting a download. r=mtigley

Comment 31

[Molly Howell (she/her) [:mhowell]]

Attachment: Bug 1724319 - Handle the possibility of the download modal not existing in a test which uses it to cancel a download. r=mtigley

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3a2b6bd72bf
Fix pdfjs component tests for when new download changes are enabled. r=Gijs

Comment 33

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1724319 - Fix remotebrowsing tests for when new download changes are enabled. r?nika,Gijs

• Adjust the test's assertions to expect the download panel to open and a new download entry to be created when the browser.download.improvements_to_download_panel pref is true

Comment 34

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d3a2b6bd72bf

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5bea658ee57
Handle the possibility of the download modal not existing in a test which uses it to cancel a download. r=mtigley

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64bededdaf4c
Fix failing tests in browser/base/content/general when new downloads pref is enabled. r=Gijs

Comment 37

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f5bea658ee57
https://hg.mozilla.org/mozilla-central/rev/64bededdaf4c

Comment 38

[:Gijs (he/him)]

Attachment: Bug 1724319 - fix storing of user preferences for protocol handler registrations with download improvements pref, r?mhowell

Comment 39

[:Gijs (he/him)]

Attachment: Bug 1724319 - fix accessibility test relying on the download modal opening to work with download improvements pref flipped, r?Jamie

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06dda9072cb7
Stop this test from depending on the download modal for starting a download. r=mtigley

Comment 41

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/06dda9072cb7

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fda24646bde
fix accessibility test relying on the download modal opening to work with download improvements pref flipped, r=Jamie

Comment 43

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4f47908b25b
fix storing of user preferences for protocol handler registrations with download improvements pref, r=mhowell

Comment 44

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7fda24646bde

Comment 45

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b47aa1f2d1c
Fix remotebrowsing tests for when new download changes are enabled. r=Gijs

Comment 46

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b4f47908b25b

Comment 47

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6b47aa1f2d1c

Comment 48

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d26d995c4c97
fix browser_open_internal_choice_persistence when downloads pref is enabled. r=mtigley

Comment 49

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/d26d995c4c97

Comment 50

[:Gijs (he/him)]

We're done! 🎉