Fix test failures when browser.download.improvements_to_download_panel pref is true
Categories
(Firefox :: Downloads Panel, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox95 | --- | fixed |
People
(Reporter: mtigley, Assigned: mtigley)
References
Details
(Whiteboard: [fidefe-Outreachy2021])
Attachments
(14 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
Bug 1724319 - Stop this test from depending on the download modal for starting a download. r=mtigley
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
This issue is for identifying test failures when the browser.download.improvements_to_download_panel
pref is true.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Comment 2•2 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mtigley, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 3•1 year ago
|
||
I'm not sure why this hasn't landed, I'll let Micah answer this when she's back from PTO.
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 4•1 year ago
|
||
This patch hasn't landed yet since the test needs to be adjusted to cleanup any created .part files.
Updated•1 year ago
|
Assignee | ||
Comment 7•1 year ago
|
||
Comment 10•1 year ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0926e8e7148 Fix tests in toolkit/mozapps/downloads/test + browser_first_download_panel.js when download pref enabled. r=mtigley https://hg.mozilla.org/integration/autoland/rev/75a253b872d4 Fix remaining failing tests in browser/components/downloads/test/browser. r=mhowell
Comment 11•1 year ago
|
||
Backed out for causing failures on browser_download_overwrite.js. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/f8b4a8e59e4e0e2f1b38a8535f9af44279af363f
Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=CikCToF7RbGNH2sZa7pulw.0&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-browser-chrome-swr-e10s%2Cbc1&revision=75a253b872d49bc6a43fef3862e399861c0e184e
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=351489228&repo=autoland&lineNumber=2791
Assignee | ||
Comment 12•1 year ago
|
||
(In reply to Cristina Cozmuta (:CrissCozmuta) from comment #11)
Backed out for causing failures on browser_download_overwrite.js. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/f8b4a8e59e4e0e2f1b38a8535f9af44279af363f
Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=CikCToF7RbGNH2sZa7pulw.0&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-browser-chrome-swr-e10s%2Cbc1&revision=75a253b872d49bc6a43fef3862e399861c0e184e
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=351489228&repo=autoland&lineNumber=2791
It looks like the failures are related to just browser_download_overwrite.js. It seems to only happen on Linux 18.04 with WebRender enabled...which I'm not sure why yet.
In the meantime, I'll go ahead and land the first part of this patch queue.
Comment 13•1 year ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48fac2760660 Fix tests in toolkit/mozapps/downloads/test + browser_first_download_panel.js when download pref enabled. r=mtigley
Comment 14•1 year ago
|
||
bugherder |
Comment 15•1 year ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/407b3b199382 Fix remaining failing tests in browser/components/downloads/test/browser. r=mhowell
Comment 16•1 year ago
|
||
Updated•1 year ago
|
Comment 17•1 year ago
|
||
bugherder |
Comment 18•1 year ago
|
||
Pushed by mhowell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/033836060d50 Fix test_handlerService_store.js when new download changes are enabled. r=mtigley
Comment 19•1 year ago
|
||
bugherder |
Comment 20•1 year ago
|
||
Updated•1 year ago
|
Comment 21•1 year ago
|
||
Pushed by mhowell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8c5fe2e40cc5 Fix toolkit downloads component tests for when new download changes are enabled. r=mtigley
Comment 22•1 year ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b69342ce707 fix browser_test_data_text_csv when downloads pref is true. r=mtigley
Comment 23•1 year ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d60211f20840 Fix browser_test_data_download when improvement downloads pref is true r=mtigley
Comment 24•1 year ago
|
||
Backed out 0b69342ce707 for failures on browser_test_data_text_csv
-
backout: https://hg.mozilla.org/integration/autoland/rev/fe7fd9b31da5356183e5e45c0b20a686c821db86
-
tier 1 failure appeared on a subsequent push
-
failure log: https://treeherder.mozilla.org/logviewer?job_id=352168160&repo=autoland&lineNumber=3887
[task 2021-09-20T23:32:31.275Z] 23:32:31 INFO - TEST-PASS | dom/security/test/general/browser_test_data_text_csv.js | file name of download should match -
[task 2021-09-20T23:32:31.275Z] 23:32:31 INFO - Leaving test bound test_with_downloads_improvement_pref_disabled
[task 2021-09-20T23:32:31.276Z] 23:32:31 INFO - Entering test bound test_with_downloads_improvement_pref_enabled
[task 2021-09-20T23:32:31.276Z] 23:32:31 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/dom/security/test/general/file_data_text_csv.html" line: 0}]
[task 2021-09-20T23:32:31.277Z] 23:32:31 INFO - Buffered messages finished
[task 2021-09-20T23:32:31.278Z] 23:32:31 INFO - TEST-UNEXPECTED-FAIL | dom/security/test/general/browser_test_data_text_csv.js | Test timed out -
[task 2021-09-20T23:32:31.279Z] 23:32:31 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-09-20T23:32:31.279Z] 23:32:31 INFO - TEST-UNEXPECTED-FAIL | dom/security/test/general/browser_test_data_text_csv.js | Uncaught exception received from previously timed out test - popupshown listener on #downloadsPanel not removed before the end of test
[task 2021-09-20T23:32:31.279Z] 23:32:31 INFO - GECKO(2628) | MEMORY STAT | vsize 3052MB | residentFast 318MB | heapAllocated 191MB
[task 2021-09-20T23:32:31.279Z] 23:32:31 INFO - TEST-OK | dom/security/test/general/browser_test_data_text_csv.js | took 45009ms
Comment 25•1 year ago
|
||
bugherder |
Assignee | ||
Comment 26•1 year ago
|
||
(In reply to Natalia Csoregi [:nataliaCs] from comment #24)
Backed out 0b69342ce707 for failures on browser_test_data_text_csv
backout: https://hg.mozilla.org/integration/autoland/rev/fe7fd9b31da5356183e5e45c0b20a686c821db86
tier 1 failure appeared on a subsequent push
failure log: https://treeherder.mozilla.org/logviewer?job_id=352168160&repo=autoland&lineNumber=3887
I suspect we're not cleaning up properly in the previous test dom\security\test\general\browser_test_data_download.js
. I've checked out a recent pull from central with this patch applied and it looks like we're getting a new failure when running the whole test directory:
dom/security/test/general/browser_test_data_download.js
FAIL Uncaught exception - at chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_download.js:108 - TypeError: can't access property Symbol.iterator, downloads._downloads is undefined
Stack trace:
test_with_downloads_pref_enabled@chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_download.js:108:20
dom/security/test/general/browser_test_data_text_csv.js
FAIL File contentType should be correct. - Got "text/html", expected "text/csv"
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1364
chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_text_csv.js:test_with_downloads_improvement_pref_enabled:81
FAIL File name should be correct. - Got "data:text/html,<body>data download</body>", expected "data:text/csv;foo,bar,foobar"
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1364
chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_text_csv.js:test_with_downloads_improvement_pref_enabled:82
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Comment 27•1 year ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56a4ee0d1065 fix browser_test_data_text_csv when downloads pref is true. r=mtigley
Comment 28•1 year ago
|
||
bugherder |
Comment 29•1 year ago
|
||
Updated•1 year ago
|
Comment 30•1 year ago
|
||
Comment 31•1 year ago
|
||
Comment 32•1 year ago
|
||
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3a2b6bd72bf Fix pdfjs component tests for when new download changes are enabled. r=Gijs
Comment 33•1 year ago
|
||
- Adjust the test's assertions to expect the download panel to open and a new download entry to be created when the
browser.download.improvements_to_download_panel
pref is true
Comment 34•1 year ago
|
||
bugherder |
Comment 35•1 year ago
|
||
Pushed by mhowell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5bea658ee57 Handle the possibility of the download modal not existing in a test which uses it to cancel a download. r=mtigley
Comment 36•1 year ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/64bededdaf4c Fix failing tests in browser/base/content/general when new downloads pref is enabled. r=Gijs
Comment 37•1 year ago
|
||
bugherder |
Comment 38•1 year ago
|
||
Updated•1 year ago
|
Comment 39•1 year ago
|
||
Comment 40•1 year ago
|
||
Pushed by mhowell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06dda9072cb7 Stop this test from depending on the download modal for starting a download. r=mtigley
Comment 41•1 year ago
|
||
bugherder |
Comment 42•1 year ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7fda24646bde fix accessibility test relying on the download modal opening to work with download improvements pref flipped, r=Jamie
Comment 43•1 year ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b4f47908b25b fix storing of user preferences for protocol handler registrations with download improvements pref, r=mhowell
Comment 44•1 year ago
|
||
bugherder |
Comment 45•1 year ago
|
||
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b47aa1f2d1c Fix remotebrowsing tests for when new download changes are enabled. r=Gijs
Comment 46•1 year ago
|
||
bugherder |
Comment 47•1 year ago
|
||
bugherder |
Updated•1 year ago
|
Comment 48•1 year ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d26d995c4c97 fix browser_open_internal_choice_persistence when downloads pref is enabled. r=mtigley
Comment 49•1 year ago
|
||
bugherder |
Assignee | ||
Updated•1 year ago
|
Comment 50•1 year ago
|
||
We're done! 🎉
Updated•1 year ago
|
Updated•1 year ago
|
Description
•